What's wrong?

Pytania dotyczące zadania

Najmniejsza z trzech liczb

Składnia Java, Poziom 2, Lekcja 8

Dyskutowane

Results is: 1, -3, 3, 5 and doesn't pass the last requirement. What I do wrong?

package pl.codegym.task.task02.task0216; /* Najmniejsza z trzech liczb */ public class Solution { public static int min(int a, int b, int c) { int min = 0; if (a <= b && a <= c) { min = a; } else if (a <= b && a <= c) { min = b; } else if (c <= a && c <= b) { min = c; } return min; } public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } }

Komentarze (4)

Popularne
Najnowsze
Najstarsze

Musisz się zalogować, aby dodać komentarz

Kamil Łukasiewicz

Poziom 3 , Poland, Poland

17 grudnia 2022, 10:30

int min = 0; if (a <= b && a <= c) { min = a; } else if (a <= b && a <= c) // tu znowu ustawiasz "a" jako najmniejsza , spróbuj (b<=a && b<=c) { min = b; } else if (c <= a && c <= b) { min = c; } return min; }

Maksim Krasnov

Poziom 47 , Kyiv, Ukraine

8 września 2022, 11:43

try to check your code with next conditions: System.out.println(min(1, -1, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); your code will generate the following output: 0 //ERROR -3 3 5 but it should be: -1 -3 3 5

Grzegorz Stawicki

Poziom 6 , Poland

7 września 2022, 12:33

Cześć, z tego co widzę to dwa pierwsze warunki sprawdzają to samo. Pierwszy if sprawdza czy a <= b oraz czy a <= c i else if robi to samo. W drugim warunku spróbuj wpisać: else if (b <= a && b <= c). Wtedy nie musisz już sprawdzać trzeciej cześci. Wystarczy wtedy else min = c;

Thomas

Poziom 41 , Bayreuth, Germany

7 września 2022, 15:25

well spotted... and you even can simplify the code some more. In the if clause you checked if a is the smallest, if so, testing ends and the else if doesn't get considered anymore (the code continues in line 22). If it is not the smallest, the else if is executed. But then you know a is not the smallest and you can omit testing it again. so that little piece of code should do

else if (b < c)
    min = b;

at this point you checked a and b. If both aren't the min, then c has to be the min ->

else
    min = c;

oh, and you do not need to do a <= check... if there is no smallest and all are equal then min is set to c. Instead of using a temp variable (min) you just could return the found value like

if ....
    return a;
else if (b < c)
    return b;
else
    return c;

lots of funny possibilities ;) (that all doesn't make the code more correct... it's just to show you some ways to optimize code and make it more readable. The problem probably will be fixed when dawid applies your suggestion).