can't get it.

Question about the task

Checking the order

Java Syntax, Level 7, Lesson 9

Resolved

please help me.

1. Read 10 words from the keyboard and add them to a list of strings.
2. Determine whether the list is ordered by increasing string length.
3. If it is not, then display the index of the first element that violates this order.

Requirements:

Declare a string list variable and immediately initialize it.
Read 10 lines from the keyboard and add them to the list.
If the list is ordered by increasing string length, then you don't need to display anything.
If the list is not ordered by increasing string length, then display the index of the first element that violates this order.

package com.codegym.task.task07.task0718; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Checking the order */ public class Solution { public static void main(String[] args) throws IOException { //write your code here BufferedReader f = new BufferedReader(new InputStreamReader(System.in)); ArrayList<String> t = new ArrayList<String>(); for(int i=0; i<10; i++){ t.add(f.readLine()); } //int a = t.get(0).length(); for(int i=1; i<t.size(); i++){ if(t.get(i--).length() > t.get(i).length()){ //int a = i+1; System.out.println(t.indexOf(t.get(i)));} break; } //System.out.println(b); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

5 June 2020, 17:19

You should start practicing indenting your code properly. The code looks like this when properly formated:

public class Solution {
    public static void main(String[] args) throws IOException {
        //write your code here
        BufferedReader  f = new BufferedReader(new InputStreamReader(System.in));
        ArrayList<String>  t = new ArrayList<String>();

        for(int i=0; i<10; i++){
            t.add(f.readLine());
        }

        for(int i=1; i<t.size(); i++){
            if(t.get(i--).length() > t.get(i).length()){
                System.out.println(t.indexOf(t.get(i)));
            }
            break; // outside the if statement
        }
    }
}

Now the first problem is that the break statement is in the body of the loop not behind a logic gate (like an if statement). It will be reached the very first loop cycle no matter what and break the loop. This needs to be fixed. The second problem is that on line 26 you decrease the value of i with the "i--". If the break statement wasnt in the body of the loop this would create an infinite loop as each new loop cycle i would increase by 1 and then that line would decrease i by 1. So the value of i each cylce would go: 1 : Loop start 0 : i-- would decrease i by 1 1 : New loop cycle i increases by 1 0 : i-- would decrease i by 1 1 : New loop cycle i increases by 1 0 : i-- would decrease i by 1 1 : New loop cycle i increases by 1 0 : i-- would decrease i by 1 1 : New loop cycle i increases by 1 until infinity, you stop the code, or the task times out.