Going mad here

Question about the task

Resolved

I am getting correct output but still not passing! And as hint I am getting this : Be sure that your solution uses FileWriter. Am I missing something ?

The main method's first parameter is file1 and the second is file2.
file1 contains lines with words separated by spaces.
Write to file2 all the words that contain numbers, for example, a1 or abc3d. Separate the words with spaces.
Close the streams.

Requirements:

The program must NOT read data from the console.
The program must read the first file's contents (use the FileReader constructor with a String parameter).
The file input stream (FileReader) must be closed.
The program should write all the words containing numbers from the first file to the second file (use FileWriter).
The file output stream (FileWriter) must be closed.

package com.codegym.task.task19.task1923; /* Words with numbers */ import java.io.*; import java.util.regex.Pattern; public class Solution { public static void main(String[] args) throws IOException { FileReader fileReader = new FileReader(args[0]); BufferedReader reader = new BufferedReader(fileReader); FileWriter fileWriter = new FileWriter(args[1], true); String check = "\\D+"; while (reader.ready()) { String data = reader.readLine(); String[] arr = data.split(" "); for (int i =0; i < arr.length; i++) { String word = arr[i]; if (!word.matches(check)) { fileWriter.write(word + " "); } } } reader.close(); fileWriter.close(); } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Goran

Level 41 , Belgrade, Serbia

21 June 2020, 13:46

solution

Ok I have found error ! Please CodeGym to fix this! Problem is in line 20, if you use aregument true you have error! You must collect all words in String and then use FileWriter to write them down, which is stupid. I tried to remove last space but didn't change problem, but I left it included in my solution. Also thanks Thomas for suggestion about regex. Here is my final solution:

FileReader fileReader = new FileReader(args[0]);

        BufferedReader reader = new BufferedReader(fileReader);

        String check = ".*\\d.*";


        String result = "";


        while (reader.ready()) {

            String data = reader.readLine();

            String[] arr = data.split(" ");

            for (int i =0; i < arr.length; i++) {

                String word = arr[i];

                if (word.matches(check)) {

                    result += word + " ";

                }

            }

        }

        result = result.substring(0,result.length()-1);

        FileWriter fileWriter = new FileWriter(args[1]);

        fileWriter.write(result);

        reader.close();
        fileWriter.close();

Thomas

Level 41 , Bayreuth, Germany

21 June 2020, 14:12

About regex you learn more here a little bit later (funny, huh?) My solution was:

try (BufferedReader in = new BufferedReader(new FileReader(args[0]));
     BufferedWriter out = new BufferedWriter(new FileWriter(args[1]))) {

    while (in.ready()) {
        String[] parts = in.readLine().trim().split("\\s+");
        for (String word : parts) {
            if (word.matches(".*\\d.*"))  out.write(word + " ");
        }
    }
} catch (IOException ignore) {}

Goran

Level 41 , Belgrade, Serbia

28 June 2020, 09:36

Very funny case they are important :D Your solution is better case have less lines of code, but you know better regex :D

Adrian

Level 27 , Spanish Town, Jamaica

26 October 2020, 04:12

huh... but your regex will match pure numbers as well, won't it. I thought this task was about alphanumeric words

Thomas

Level 41 , Bayreuth, Germany

21 June 2020, 13:11

useful

your regex won't match numbers in a word. !\\D+ is the same as \\d+ and that just matches digits. However there may be or not any number of letters berfore or after a digit. Any letter is represented in regex by a . Any number of this letter (from zero to any number) is done by * so your regex should look like ".*\d.*" (and you will have to remove the not operator)

Goran

Level 41 , Belgrade, Serbia

21 June 2020, 13:36

I have try that and still not passing :/ I have same suggestion check that you are using FileWriter Can you tell me please where I can find more info about regex ?