Ship class's nextFrame() method - problem with loop Animation mode

Question about the task

Resolved

Hi, I've got problem with condition: The Ship class's nextFrame() method must set frameIndex to 0 if frameIndex is greater than or equal to the number of frames in the frames list and loopAnimation is true. My nextFrame() method looks like this:

public void nextFrame() {
    frameIndex++;

    if(loopAnimation) {
        if(frameIndex > frames.size()) {
            frameIndex = 0;
        }
    } else if(frameIndex < frames.size()) {
        setMatrix(frames.get(frameIndex));
    }
}

It passes all other conditions. I don't have any idea how to change if statements so it will matches the conditions, I tried many options. Can anyone has idea or any hint for that?

Let's make the boss animate continuously. To do this, we need to give the setAnimatedView method an isLoopAnimation parameter responsible for indicating whether the animation should loop.
This parameter is used to properly set the loopAnimation field.
If the loopAnimation field is true, the nextFrame method repeats the frames by resetting frameIndex.
As a result, you need to refactor the parameters in places where the setAnimatedView method is called.

Requirements:

The Ship class must have a private boolean loopAnimation field that is initialized to false when it is declared.
The Ship class must have a public void setAnimatedView(boolean isLoopAnimation, int[][]... viewFrames) method.
The Ship class must not have a public void setAnimatedView(int[][]... viewFrames) method.
The setAnimatedView(boolean isLoopAnimation, int[][]... viewFrames) method must set the loopAnimation field equal to the value of isLoopAnimation.
The Ship class's nextFrame() method must not do anything if frameIndex is greater than or equal to the number of frames in the frames list and loopAnimation is false.
The Ship class's nextFrame() method must set frameIndex to 0 if frameIndex is greater than or equal to the number of frames in the frames list and loopAnimation is true.
In the PlayerShip class's kill() method, you need to call the base class's setAnimatedView(boolean, int[][]...) method with the following arguments: false, ShapeMatrix.KILL_PLAYER_ANIMATION_FIRST, ShapeMatrix.KILL_PLAYER_ANIMATION_SECOND, ShapeMatrix.KILL_PLAYER_ANIMATION_THIRD, ShapeMatrix.DEAD_PLAYER.
In the EnemyShip class's kill() method, you need to call the base class's setAnimatedView(boolean, int[][]...) method with the following arguments: false, ShapeMatrix.KILL_ENEMY_ANIMATION_FIRST, ShapeMatrix.KILL_ENEMY_ANIMATION_SECOND, ShapeMatrix.KILL_ENEMY_ANIMATION_THIRD.
In the Boss class's kill() method, you need to call the base class's setAnimatedView(boolean, int[][]...) method with the following arguments: false, ShapeMatrix.KILL_BOSS_ANIMATION_FIRST, ShapeMatrix.KILL_BOSS_ANIMATION_SECOND, ShapeMatrix.KILL_BOSS_ANIMATION_THIRD.
In the Boss class's constructor, you need to call the base class's setAnimatedView(boolean, int[][]...) method with the following arguments: true, ShapeMatrix.BOSS_ANIMATION_FIRST, ShapeMatrix.BOSS_ANIMATION_SECOND.

package com.codegym.games.spaceinvaders; public enum Direction { RIGHT, LEFT, UP, DOWN }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Magda

Level 19 , Torun, Poland

1 July 2020, 11:29

Thanks! I did as you wrote and cut out else statement and then it passes

Niklas Braun

Level 33 , Freiburg, Germany

30 June 2020, 21:21

solution

the task says: "greater or equal". You only check if it is greater. Instead of ">", try to do it with ">=". Then you can also replace the else if statement by an else statement.