where i'm wrong. I can't be getting the bug.

Question about the task

Vowels and consonants

Java Syntax, Level 9, Lesson 11

Resolved

pls help🙏🙏

Write a program that reads a string from the keyboard.
The program should display two lines:
1. The first line contains only the vowels from the entered string.
2. The second contains only the consonants and punctuation marks from the entered string.
The letters should be separated by a space, each line must end with a space.

Example input:
Sam I Am.

Example output:
a I A S m m .

Requirements:

The program must read data from the keyboard.
The program should display two lines.
The first line should contain only the vowels from the input string, separated by a space.
The second line should contain only the consonants and punctuation marks from the input string, separated by a space.
Each line must end with a space.

package com.codegym.task.task09.task0923; import java.io.BufferedReader; import java.io.InputStreamReader; /* Vowels and consonants */ public class Solution { public static char[] vowels = new char[]{'a', 'e', 'i', 'o', 'u'}; public static char getCharFromString (String str, int index){ return str.toCharArray()[index]; } public static void main(String[] args) throws Exception { // write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String s = reader.readLine(); int n = s.length(); char[] ch = new char[n]; for (int i=0; i<n; i++){ char a = getCharFromString (s, i); ch[i] = a; } for (int i=0; i<n; i++){ if (isVowel(ch[i])){ System.out.print(ch[i]); } System.out.println(); for (int i=0; i<n; i++){ if (!isVowel(ch[i])){ System.out.print(ch[i]); } } } // The method checks whether a letter is a vowel public static boolean isVowel(char c) { c = Character.toLowerCase(c); // Convert to lowercase for (char d : vowels) // Look for vowels in the array { if (c == d) return true; } return false; } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

7 July 2020, 14:26

In line 40 a closing curly bracket is missing. And you need to filter out whitespace... like

if (isVowel(ch[i]) && ch[i] != ' ') {

Even better would be (resourcewise) to just convert the string to a char array once. And before you do that to remove all spaces. Than you just iterate once over the array (eg. with a for-each loop), do your comparison and if it's a vowel add to vowel string, else to the nonVowel string. Another possibility is to use the String method charAt()

Tata

Level 16 , Hisar, Haryana, India

7 July 2020, 15:26

Thank you for your explanation.

Brad Reed

Level 19 , Hartford, United States

9 July 2020, 02:37

I cant seem to get any of the space removal to work. Ive tried the iteration you used here, I wet to stack overflow and tried the .removeAll("//s",""); and that threw an error saying removall was an unknown. The one you posted here gives me incompatible character types errors.

Thomas

Level 41 , Bayreuth, Germany

9 July 2020, 06:23

You can have a look at the Java docs for a list of all methods you can use on strings. Here you can use replaceAll as argument you can give it eg. a space and nothing like replaceAll(" ","") That already would work here. Another possibility is to use regex in order to find one or more whitespaces in a series and replace with nothing like replaceAll("\\s+", ""). In the end you could write eg.

for (char c : reader.readLine().replaceAll("\\s+", "").toCharArray()) {
     if (isVowel(c)) ....
     else ....