Why do I get this output?

Question about the task

Archived

This as23dds asd twelve 23 twelve34 file file
Asds we four twelve 1990 file vifourew
Ssd WD one nine 2020 file view In
ZX2 EW eleven 28 1998 file in in
Bns afef two two3 1999 file file file
Ss2d sef sd six ten 1995 in view
Asds four 19 1992 in in
Asd3s seven 1seven 2012 view view

1. In a static block, initialize map with (number, word) pairs from 0 to 12 inclusive.
For example, (0, "zero"), (1, "one"), (2, "two")
2. Read the file name from the console, and then read the contents of the file.
3. Use map to replace all of the numbers with words.
4. Display the result.
5. Close the streams.

Example file data:
This costs 1 dollar, but this is 12. The variable is called file1. 110 is a number.

Example console output:
This costs one dollar, but this is twelve. The variable is called file1. 110 is a number.

Requirements:

The Solution class must have a public static Map<Integer, String> field called words that is initialized immediately.
The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program should write all of the lines from the file to the console, but any numbers must be replaced with the corresponding words in map.
The Solution class must have a static block that adds thirteen pairs to map.

package com.codegym.task.task19.task1924; import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.HashMap; import java.util.Map; import java.util.Scanner; /* Replacing numbers */ public class Solution { public static Map<Integer, String> map = new HashMap<Integer, String>(); static{ map.put(0, "zero"); map.put(1, "one"); map.put(2, "two"); map.put(3, "three"); map.put(4, "four"); map.put(5, "five"); map.put(6, "six"); map.put(7, "seven"); map.put(8, "eight"); map.put(9, "nine"); map.put(10, "ten"); map.put(11, "eleven"); map.put(12, "twelve"); } public static boolean isNumber( String input){ try{ Integer.parseInt(input); return true; }catch (Exception e){ return false; } } public static void main(String[] args)throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); FileReader fileReader = new FileReader(reader.readLine()); reader.close(); Scanner scanner = new Scanner(fileReader); int count = 0; while (scanner.hasNext()){ count = 0; String line = scanner.nextLine(); String[] lineArr = line.split(" "); for (int i = 0 ; i < lineArr.length; i++){ if (isNumber(lineArr[i])){ for (Map.Entry<Integer, String> entry : map.entrySet()){ if (Integer.parseInt(lineArr[i])==(entry.getKey())){ line = line.replace(lineArr[i], entry.getValue()); count++; } } } } System.out.println(line); } fileReader.close(); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

7 July 2020, 16:40

Whe you loop through the map Map, the first key that's getting checked is 1. If one of the line parts matches 1, all 1s get replaced with one. input: This costs 1 dollar, but this is 12. output: This costs one dollar, but this is one2. When your loop reaches 12, it still matches the part but when trying to replace the match it isn't there anymore in the line as the 1 already has been replaced. I can think of two solutions. 1. Instead of replace use replaceAll and a regex making use of word borders 2. Start the loop from the end of the map

David

Level 26 , Bucharest, Romania

7 July 2020, 16:59

Sorry, but is not all clear tmo me! So once it gets here, isn't it checking for every key from the map if is equals with that string (lineArr[i])?

for (Map.Entry<Integer, String> entry : map.entrySet()){
                        if (Integer.parseInt(lineArr[i])==(entry.getKey())){
                            line = line.replace(lineArr[i], entry.getValue());
                        }
                    }

So after it makes the check for every key from the map, it goes to the next string from array.. And I dont understand why is happeneing this: input: This costs 1 dollar, but this is 12. output: This costs one dollar, but this is one2. Since a have the condition, and makes the replace only if the string is equal to the key

if (Integer.parseInt(lineArr[i])==(entry.getKey()))

Thomas

Level 41 , Bayreuth, Germany

7 July 2020, 17:03

you enter the loop, the first check is against 1. If the line part (lineArr[i]) matches, then you start the replacement. The replacement however is not within the line part but you replace in the entire line. In the example there are two 1s. The one you want to replace and the 1 within 12.

David

Level 26 , Bucharest, Romania

7 July 2020, 17:16

ok, I got it. Thank you!!