Returns the right answer but does not pass.

Question about the task

Under discussion

So this program returns "Minimum = -79" but does not pass the following two requirements. 1. "The class must have a public static min method that takes 5 int arguments." 2. "The min method must return the minimum of the 5 passed numbers. If there are several minimum numbers, return any of them." Could someone please explain to me what is wrong with my code? Thank you :)

Current implementation: The program reads two numbers from the keyboard and displays the minimum.
New task: The program reads five numbers from the keyboard and displays the minimum.

Requirements:

The program should read the numbers from the keyboard.
The class must have a public static void main method.
The class must have a public static min method that takes 5 int arguments.
The min method must return the minimum of the 5 passed numbers. If there are several minimum numbers, return any of them.
The program should display a string that starts with "Minimum = ".
The program should display a string that ends with the minimum of the 5 entered numbers.

package com.codegym.task.task05.task0531; import java.io.BufferedReader; import java.io.InputStreamReader; /* Improving functionality */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int y =Integer.parseInt(reader.readLine()); int x =0; for(int i=1;i!=5;i++){ x =Integer.parseInt(reader.readLine()); y =min(y,x); } System.out.println("Minimum = " + y); } public static int min(int a, int b) { return a < b ? a : b; } } /*original: package com.codegym.task.task05.task0531; import java.io.BufferedReader; import java.io.InputStreamReader; public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); int b = Integer.parseInt(reader.readLine()); int minimum = min(a, b); System.out.println("Minimum = " + minimum); } public static int min(int a, int b) { return a < b ? a : b; } } */

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

9 July 2020, 06:40

your loop doesn't iterate over 5 items I suggest to always use the same type of setup for loops. In view of arrays it is very common to use something like this for (int i = 0; i < 5; i++) you know at the first view that it starts at the first (array, list) element (0) and it iterates over 5 items. Then the task asks for a min method that takes 5 arguments and returns the minimum. You have a min method that just takes 2 arguments.

Rebekah H

Level 8 , Gothenburg, Sweden

13 July 2020, 16:04

That cant be it thou. It returns -79 at the minimum number, but it is also the last number, hence surely it must run 5 times? When I use your method, or change my i=1 to i=0, I get this output

java.lang.NumberFormatException: null
	at java.lang.Integer.parseInt(Integer.java:542)
	at java.lang.Integer.parseInt(Integer.java:615)
	at com.codegym.task.task05.task0531.Solution.main(Solution.java:20)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

Thomas

Level 41 , Bayreuth, Germany

13 July 2020, 16:54

Yes, you're right, your loop just needs to read four numbers as you already read one before. Still you need to write a min method that has 5 parameters. Your approach is good but validation asks for something else.