Whats wrong with this code?

Question about the task

Resolved

This code works when I dont use the word else in the line 17. but it doesnt work when I type the word else in line 17

package com.codegym.task.task02.task0216;

/*
Minimum of three numbers

*/
public class Solution {
    public static int min(int a, int b, int c) {
        //write your code here
        if(a<b)
        {
            if (a<c)
            {
                return a;
            }
        }
         else if (b<c)
        {
            return b;
        }

        else
        {
            return c;
        }


    }

    public static void main(String[] args) throws Exception {
        System.out.println(min(1, 2, 3));
        System.out.println(min(-1, -2, -3));
        System.out.println(min(3, 5, 3));
        System.out.println(min(5, 5, 10));
    }

}

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

HSK

Level 4 , Karachi, Pakistan

26 November 2018, 12:52

you cant use only greater than in this because in the main method in 3rd and 4th line of system.out.print two numbers are same... use greater than and equal to

Love Patel

Level 5 , San Leandro, United States

26 November 2018, 22:56

no thats not the problem. the logic is fine i think. The problem arises when i use "else if" on line 17. It works completely fine when i remove the word else from line 17.

Khurram

Level 16 , Lahore, Pakistan

26 November 2018, 10:27

the method should return an int and since the return statements are inside conditional code blocks, the method may or may not return an int, hence the compiler makes sure that either the if part or the else part should return an int

Love Patel

Level 5 , San Leandro, United States

26 November 2018, 22:54

why would it not return an int ? a,b,c are all ints. The code works if I remove the word else from line 17

Khurram

Level 16 , Lahore, Pakistan

27 November 2018, 06:08

useful

consider the if statement on line 10 is true and the if statement on line 12 is false, the program will not return anything because the else-if part on line 17 will not be executed, but the method should an int because that is the method return type when you remove the else on line 17, even when the if on line 10 is false, there is a separate if / else block at lines 17 and 22. when the if at line 17 is true it will return an int, and when it is false, the else part will also return an int

Love Patel

Level 5 , San Leandro, United States

27 November 2018, 06:54

Ok thankyou! I got it! If I put another else inside the first if block after line 15 and return c that will do it! and then else if will work! Thankyou!

Love Patel

Level 5 , San Leandro, United States

27 November 2018, 06:56

solution

This doest it: Thanks again!

package com.codegym.task.task02.task0216;

/*
Minimum of three numbers

*/
public class Solution {
    public static int min(int a, int b, int c) {
        //write your code here
        if(a<b)
        {
            if (a<c)
            {
                return a;
            }
            else return c;
        }
        else if (b<c)
        {
            return b;
        }

        else
        {
            return c;
        }


    }

    public static void main(String[] args) throws Exception {
        System.out.println(min(1, 2, 3));
        System.out.println(min(-1, -2, -3));
        System.out.println(min(3, 5, 3));
        System.out.println(min(5, 5, 10));
    }

}

Sushant

Level 4 , goa, india

4 March 2019, 10:15

follow this solution u will get the result.