why am I getting out of memory error on java heap

Question about the task

Under discussion

I am getting out of memory error on java heap help me resolving the issue

1. Create a list of words and populate it yourself.
2. The fix method should:
2.1. remove all words containing the letter "r" from the list
2.2. duplicate all words containing the letter "l".
2.3. if a word contains both "r" and "l", then leave it unchanged.
2.4. don't do anything to other words.

For example:
rose lyre love

Output:
lyre love love

Requirements:

The program must not read data from the keyboard.
The fix method should remove all words containing the letter "r" from the list. There is an exception: words containing both "r" and "l" should be left alone.
The fix method must duplicate words containing the letter "l" (add another instance of this word to the list). There is an exception: words containing both "l" and "r" should not be duplicated.
The fix method should not do anything with words that contain both "l" and "r".
The fix method should not do anything with words that don't contain either "l" or "r".

package com.codegym.task.task07.task0716; import java.util.ArrayList; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("rose"); // 0 list.add("love"); // 1 list.add("lyre"); // 2 list = fix(list); for (String s : list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { for(int i =0; i<list.size(); i++) { int index = list.get(i).indexOf("r"); int index1 = list.get(i).indexOf("l"); if (index >= 0 && index1 < 0) list.remove(i); } //System.out.println(list.size()); for(int i =0; i<list.size(); i++) { int index = list.get(i).indexOf("r"); int index1 = list.get(i).indexOf("l"); if (index < 0 && index1 >= 0) list.add(i, list.get(i)); } return list; } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Riya

Level 15 , Indore, India

18 July 2020, 15:17

index cant be less than 0

Gellert Varga

Level 23 , Szekesfehervar, Hungary

14 July 2020, 11:06

- in the first "for" cycle, you need to apply an extra i-- command, after line 30, but inside the "if"-thread. (If you remove an item, then at the same index of the list will be a newcomer item, from the right side! And you have to check this too, you should not to skip this. But the head of the loop would like to increase the "i", and it would skip this item this way.) - in the second "for" cycle, you need to apply an extra i++ command, inside the "if"-thread, after line 37. Without this, if you add a new item, in the next circle of the loop you check the same item (the duplicated item), and you will duplicate it again, and again, and again... = infinite loop.

ion

Level 8 , Athens, Greece

13 July 2020, 21:37

In the for loops you can't add and remove objects from the same list that the for loop reads. You have to create a new list before the for loops for example : ArrayList<String> newlist = new ArrayList<String>(); in the "newlist" you can add the double words that contain the letter 'l' and for the words that contain the letter 'r' just skip the word don't add it in the "newlist". (Faking the "removing" of the word) At the end of the function return the "newlist" and you're done.

Gellert Varga

Level 23 , Szekesfehervar, Hungary

14 July 2020, 11:17

I think not. See above. What you're talking about is: "foreach" loop. for (int i : list) { . . . } But the cycle (in question) is not like that.