help me

Question about the task

Two in one

Java Core, Level 8, Lesson 11

Resolved

It tells the first file is not closed but i have closed it after it finishes it's work

Read 3 file names from the console.
Write the contents of the second file to the first file, and then append the contents of the third file to the first file.
Close the streams.

Requirements:

The program should read a file name three times from the console.
Create an output stream for the first file. For the other two, create input streams.
The contents of the second file must be copied to the first file.
The contents of the third file must be appended to the first file (after the second file has been written to the first file).
The file streams must be closed.

package com.codegym.task.task18.task1818; import java.io.*; import java.util.*; /* Two in one */ public class Solution { public static void main(String[] args) throws Exception{ BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); FileOutputStream fis1 = new FileOutputStream(br.readLine()); FileInputStream fis2 = new FileInputStream(br.readLine()); FileInputStream fis3 = new FileInputStream(br.readLine()); byte[] buffer = new byte[fis2.available()]; int count = fis2.read(buffer); fis1.write(buffer,0,count); fis1.close(); fis2.close(); byte[] buffer1 = new byte[fis3.available()]; int count1 = fis3.read(buffer1); fis1.write(buffer1); fis1.close(); fis3.close(); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

13 August 2020, 13:58

useful

Make sure that you always test your code. Line 22 closes fis1, but the code attempts to use it again on line 27. This will throw an exception. The task can't pass and with literally infinite ways to do something wrong, the validator will not always be able to tell you exactly where/what the problem is.

dhanush

Level 30 , Chennai, India

13 August 2020, 14:17

I have done by closing the outputstream at the end of the program in the before i came for help in the help section but even though it tells first file is not closed

byte[] buffer = new byte[fis2.available()];
       int count = fis2.read(buffer);

       fis1.write(buffer,0,count);
       fis2.close();

       byte[] buffer1 = new byte[fis3.available()];
       int count1 = fis3.read(buffer1);
       fis1.write(buffer1);
       fis3.close();

       fis1.close();

Guadalupe Gagnon

Level 37 , Tampa, United States

13 August 2020, 15:25

solution

I dont see anything wrong with your code, though you can try changing line 21 to:

fis1.write(buffer);

Because you are reading and writing the entire file in one shot, you don't need to specify start and end points (the second and third argument of the write() method). This may be causing a problem, though I am not 100%. You can try resetting the task, then copy/paste the solution back in. This sometimes clears any errors. The last possibility is that the validation system on this task has a bug in its algorithm. If that is the case then you won't be able to pass. I would suggest if nothing else works then to skip this for now and try again next week.

dhanush

Level 30 , Chennai, India

13 August 2020, 16:23

I think don't need for that it passes the validation. I thought from the second file to copy the whole to the first file may require to set the value of length,may be some bytes may not be copied if we mention the computer the perform to copy the whole by putting the arguments may not leaves any hole in the file. Anyways just by setting the value

bytes[] buffer = new bytes[fis1.available()];
fis1.write(buffer);

copies the file thanks for your explanation.