Can someone explain me why this is not working ? :(

Question about the task

Expressing ourselves more concisely

Java Syntax, Level 7, Lesson 6

Archived

Is this just bugged or ...??

1. Create a list of strings.
2. Read 5 strings from the keyboard and add them to the list.
3. Using a loop, find the shortest string in the list.
4. Display the string.
5. If there is more than one, display each on a new line.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 5 strings from the keyboard and write them to the list.
The program should display the shortest string.
If several strings are the shortest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0709; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.Scanner; /* Expressing ourselves more concisely */ public class Solution { public static void main(String[] args) throws Exception { Scanner scanner = new Scanner(System.in); ArrayList<String> arr = new ArrayList<>(); ArrayList<String> temp = new ArrayList<>(); for (int i = 0; i < 5; i++) { String s = scanner.next(); arr.add(s); } int min = arr.get(0).length(); for (int j = 0; j < arr.size(); j++) if (arr.get(j).length() < min) { min = arr.get(j).length(); } for (int i = 0; i < 5; i++) { if (arr.get(i).length() == min) { temp.add(arr.get(i)); } } for (int j = 0; j < temp.size(); j++) { System.out.println(temp.get(j)); } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Darek

Level 41 , Katowice, Poland

21 August 2020, 06:59

Fact, 1 list is enough. In fact, one loop is enough at the end. Logically, you have the same, but you confused yourself too much :) I used: BufferedReader reader = new BufferedReader (new InputStreamReader (System.in)); You have 3 loops: 1. Read the data from the keyboard with a scanner or reader and save it to the list for (int i = 0; i <5; i ++) { String a = reader.readLine (); strings.add (a); } 2. The length of the first item in the list is given as a minimum 3. In the second loop you compare all the lengths of the list items to find the shortest. min = strings.get (0) .length (); for (int i = 0; i <strings.size (); i ++) { if (strings.get (i) .length () <min) { min = strings.get (i) .length (); } } 4. In the third loop you check the list items to find all of the shortest length and print them. for (int k = 0; k <strings.size (); k ++) { if (strings.get (k) .length () == min) { System.out.println (strings.get (k)); } }

Guadalupe Gagnon

Level 37 , Tampa, United States

17 August 2020, 20:07

The big bug in the code is that the inputs should consist of full strings, which means 1 input is anything entered in before the user hits enter. So the string: "When you feel like quitting, think about why you started" that should be entered in as one long entry. In this code if that was entered first the code would then output "you" and end. This is a bug in the code that needs to be addressed first before you continue.

Gytis Laukaitis Full Stack Developer

17 August 2020, 19:49

Wasn't mentioned in description how many loops i should use. As i test it on Intellij ,it works just fine, but here it fails. Well thanks anyway :)

Agent Smith

Level 38

17 August 2020, 19:40

Hmm, maybe it doesn't like that you have 2 lists? The second one is actually redundant. After line 29 you only need a single line of code instead of 2 additional for-loops:

for(String s : arr) if(s.length() == min) System.out.println(s);