Still failing after fixing comments

Question about the task

Under discussion

Hi, Previously I had issue with comments, but it was fixed and I was able to load from txt with the same content as on Wikipedia. Could you please check? Thanks

In the fillInPropertiesMap method, read a file name from the console and populate the properties map with data from the file.
You can read about .properties here: http://en.wikipedia.org/wiki/.properties
Implement the logic for file IO for the properties map.

Requirements:

The fillInPropertiesMap method must read data from the console.
The fillInPropertiesMap method must create a FileInputStream, passing the read string as an argument.
The fillInPropertiesMap method should call the load method, passing the newly created FileInputStream as an argument.
The save method must store the properties map in the OutputStream object passed as an argument.
The load method must restore the state of the properties map from the InputStream object passed as an argument.

package com.codegym.task.task20.task2003; import java.io.*; import java.util.*; import java.util.regex.Matcher; import java.util.regex.Pattern; /* Introducing properties */ public class Solution { public static Map<String, String> properties = new HashMap<>(); public void fillInPropertiesMap() throws Exception { BufferedReader consoleReader = new BufferedReader(new InputStreamReader(System.in)); String filename = consoleReader.readLine(); consoleReader.close(); FileInputStream fileInputStream = new FileInputStream(filename); load(fileInputStream); } public void save(OutputStream outputStream) throws Exception { for (Map.Entry<String, String> pair : properties.entrySet()) { Property property = new Property(pair.getKey(), pair.getValue(), (pair.getValue().trim().startsWith("\\u")) ? ":" : "=" ); outputStream.write(property.toString().getBytes()); outputStream.write("\n".charAt(0)); } } public void load(InputStream inputStream) throws Exception { properties.clear(); byte[] buffer = new byte[inputStream.available()]; inputStream.read(buffer); String allPropertiesSerialized = new String(buffer); String[] allProperties = allPropertiesSerialized.split("\n"); List<String> allPropertiesNormalized = new ArrayList<>(); int i = 0; boolean mustBeConcat = false; while (i<allProperties.length) { if (!mustBeConcat & (allProperties[i].startsWith("#") || allProperties[i].startsWith("!"))) { i++; continue; } if (mustBeConcat && allProperties[i].endsWith("\\") && !allProperties[i].endsWith("\\\\")) { allPropertiesNormalized.set(allPropertiesNormalized.size() - 1, allPropertiesNormalized.get(allPropertiesNormalized.size() - 1) + System.lineSeparator() + allProperties[i]); mustBeConcat = true; } else if (mustBeConcat & !(allProperties[i].endsWith("\\") && !allProperties[i].endsWith("\\\\"))) { allPropertiesNormalized.set(allPropertiesNormalized.size() - 1, allPropertiesNormalized.get(allPropertiesNormalized.size() - 1) + System.lineSeparator() + allProperties[i]); mustBeConcat = false; } else if (!mustBeConcat && allProperties[i].endsWith("\\") && !allProperties[i].endsWith("\\\\") ) { allPropertiesNormalized.add(allProperties[i]); mustBeConcat = true; } else { allPropertiesNormalized.add(allProperties[i]); mustBeConcat = false; } i++; } String patternString = "[^\\\\](=|:)"; Pattern pattern = Pattern.compile(patternString); for (String s : allPropertiesNormalized) { Matcher matcher = pattern.matcher(s); while (matcher.find()) { String key = s.substring(0, matcher.start()+1).trim(); String value = s.substring(matcher.start()+2).trim(); properties.put(key, value); break; } } } public static void main(String[] args) throws Exception { properties.put("website", "https://en.wikipedia.org/"); properties.put("language", "English"); properties.put("message", "Welcome to \\\n" + " Wikipedia!"); properties.put("key", "valueOverOneLine\\\\"); properties.put("key\\:with\\=colonAndEqualsSign", "This is the value for the key \"key:with=colonAndEqualsSign\""); properties.put("tab", "\\u0009"); properties.put("path", "c:\\\\wiki\\\\templates"); File yourFile = File.createTempFile("your_file_name", null); OutputStream outputStream = new FileOutputStream(yourFile); InputStream inputStream = new FileInputStream(yourFile); Map<String, String> copy = new HashMap<>(properties); Solution solution = new Solution(); solution.save(outputStream); Solution otherSolution = new Solution(); solution.load(inputStream); for (Map.Entry<String, String> pair : properties.entrySet()) { //System.out.println(pair.getKey() + " EQUALITY " + pair.getValue()); if (!copy.containsKey(pair.getKey())) { System.out.println("Not found key: " + pair.getKey()); } else { if (!pair.getValue().equals(copy.get(pair.getKey()))) { System.out.println("Value not equal: <" + pair.getValue() + "<, <" + copy.get(pair.getKey()) + ">"); } } } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Nyerges Ferenc

Level 26 , Bükkábrány, Hungary

28 November 2020, 09:20

I suggest just google for java Properties class - that will do the job

Guadalupe Gagnon

Level 37 , Tampa, United States

19 August 2020, 18:41

In the save method, line 27 should be getBytes(). This could be the cause of your problems as the validation system will use your save method then use the load method on what was saved to make sure that they both work properly. Also, as a tip, a strategy that I use so there isn't any extra spaces or new line characters at the end of any results goes something like this (replacing the code in the save method):

//first check that map has values, no need to continue if there are no entries
if(properties.size() > 0){
   // create an iterator then get the first item and write it to the file
   Iterator<Map.Entry<String, String>> itr = properties.entrySet().iterator();
   Map.Entry<String, String> entry = itr.next();
   Property property = new Property(/*args from entry*/);;
   outputStream.write(property.getBytes());

   // write all the rest of the items in map starting with a new line character
   while (itr.hasNext()) {
      entry = itr.next();
      property = new Property(/*args from itr*/);
      outputStream.write(("\n" + property).getBytes());
   }
}

By using an Iterator instead of a foreach loop you can write the first key/value without a line break and then start the subsequent items in the Map with the line break. This will mean a much cleaner end result, which in code we should all be striving to achieve. The output from your code would be: line 1/n line 2/n line 3/n While the output from this code would be: line 1/n line 2/n line 3