What am I doing wrong? Thanks.

Question about the task

Under discussion

public class Solution { public static void main(String[] args) { try{FileInputStream stream = new FileInputStream(args[0]); int n1 = 0; int n2 = 0; int a; while (stream.available() > 0) { a =stream.read(); n1 += a; String c = Integer.toString(a); if(c == " ") n2 ++; } stream.close(); double d = (double)Math.round((n2/n1*100)*100d)/100d; System.out.println(d);} catch(IOException e){} } }

The first parameter of the main method is a file name.
Display the ratio of the number of spaces to the number of all characters. For example, 10.45.
1. Count all the characters (n1).
2. Count the spaces (n2).
3. Display n2/n1*100, rounding to 2 decimal places.
4. Close the streams.

Requirements:

You don't need to read anything from the console.
Create a stream to read from the file passed as the first argument of the main method.
Calculate and display the ratio of the spaces to all characters in the file.
The displayed value must be rounded to 2 decimal places.
The stream used to read the file must be closed.

package com.codegym.task.task18.task1817; import java.io.FileInputStream; import java.io.IOException; /* Spaces */ public class Solution { public static void main(String[] args) { try{FileInputStream stream = new FileInputStream(args[0]); int n1 = 0; int n2 = 0; int a; while (stream.available() > 0) { a =stream.read(); n1 += a; String c = Integer.toString(a); if(c == " ") n2 ++; } stream.close(); double d = (double)Math.round((n2/n1*100)*100d)/100d; System.out.println(d);} catch(IOException e){} } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

20 December 2018, 20:05

First, the stream.available() returns the total bytes in the file. You should save that in a variable before your start reading.

n1 = stream.available();

Next, read returns a number that corresponds to the Ascii table. 32 is the number that is returned from each space. There is no need to convert it to a string, just use:

if(stream.read() == 32) n2++;

you can get rid of most the code that is not needed when you add those two things. Then fix line 26 to read:

double d = Math.round((n2/(double)n1*100)*100)/100d;

Abhishek Rangari

Level 22 , Nagpur, India

20 December 2018, 18:20

few things I need to highlight which is -

a =stream.read();
        n1 += a;  // do not perform this operation just increment the n1++ for every character including spaces
// like n1++;
        String c = Integer.toString(a);// no need of this
        if(c == " ") // make this condition like this if(a == 32)  n2++ , as from input stream you will get bytes in
// integer therefore you need to compare value based on the ascii value,  so for " "(space) 32 is the number

and for printing decimal value upto two decimal points refer @Mack's comments / code