Mistake in my ifs

Question about the task

Improving functionality

Java Syntax, Level 5, Lesson 12

Under discussion

Hey, I think there is something wrong in my ifs can someone check that, please? Thanks!

Current implementation: The program reads two numbers from the keyboard and displays the minimum.
New task: The program reads five numbers from the keyboard and displays the minimum.

Requirements:

The program should read the numbers from the keyboard.
The class must have a public static void main method.
The class must have a public static min method that takes 5 int arguments.
The min method must return the minimum of the 5 passed numbers. If there are several minimum numbers, return any of them.
The program should display a string that starts with "Minimum = ".
The program should display a string that ends with the minimum of the 5 entered numbers.

package com.codegym.task.task05.task0531; import java.io.BufferedReader; import java.io.InputStreamReader; /* Improving functionality */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); int b = Integer.parseInt(reader.readLine()); int c = Integer.parseInt(reader.readLine()); int d = Integer.parseInt(reader.readLine()); int e = Integer.parseInt(reader.readLine()); int minimum = min(a, b, c, d, e); System.out.println("Minimum = " + minimum); } public static int min(int a, int b, int c, int d, int e) { if((a <= b) && (a <= d) && (a <= c) && (a <= e)) { } return a; else if((b <= a) && (b <= d) && (b <= c) && (b <= e)) { } return b; else if((c <= a) && (c <= b) && (c <= d) && (c <= e)) { } min = c; else if((d <= a) && (d <= b) && (d <= c) && (d <= e)) { } return d; else((e <= a) && (e <= b) && (e<=c) && (e<=d)) { } return e; } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Sela

Level 20 , Poland

18 September 2020, 05:44

try bubble sort approach. it means that for sake of simplicity you compare only two digits in this fashion (following is the body of method):

int min = a;//assume a is the minimum
if (b < min) min = b;//or maybe b etc...
if (c < min) min = c;
if (d < min) min = d;
if (e < min) min = e;
return min;

if you are familiar with loops and arrays already then you use only one line with if statement and repeat it in a loop

Laura

Level 7 , Lübeck, Deutschland

18 September 2020, 18:29

Thank u I could pass it with my long code but I understand yours and will try it, thanks! I'm not that familiar with loops yet and I cant make array list yet but surely I will learn it!!

Misiu

Level 41 , Gdansk, Poland

17 September 2020, 16:59

Wrong places of closing brackets }. Line 36, should be: return c; Remove lines 40, 41. There is no return if all results are in IFs.