Where is the logical error?

Question about the task

Resolved

The Car create(int, int) method must return a Car object based on the passed argument. I think my solution is correct, but I can't pass validation? Please give me an advice. Thanks in advice.

Understand the code in the car package.
10.1. Replace a constructor with a factory method.
10.1.1. Declare Truck, Sedan, and Cabriolet classes that inherit Car.
10.1.2. Add constructors that have an int numberOfPassengers constructors.
10.1.3. Add a static Car create(int type, int numberOfPassengers) factory method to the Car class and implement it.
10.1.4. Change the visibility of the Car class constructor.

Requirements:

You need to create Truck, Sedan, and Cabriolet classes that inherit Car.
You need to add constructors with int numberOfPassengers parameters to the created classes.
You need to add a static Car create(int type, int numberOfPassengers) factory method to the Car class and implement it.
You need to change the visibility of the Car class constructor from public to protected.

package com.codegym.task.task29.task2909.car; import java.util.Date; public class Car { static public final int TRUCK = 0; static public final int SEDAN = 1; static public final int CABRIOLET = 2; double fuel; public double summerFuelConsumption; public double winterFuelConsumption; public double winterWarmingUp; private int type; private boolean driverAvailable; private int numberOfPassengers; protected Car(int type, int numberOfPassengers) { this.type = type; this.numberOfPassengers = numberOfPassengers; } public static Car create(int type, int numberOfPassengers) { if (type == 0) { return new Cabriolet(numberOfPassengers); } else if (type == 1) { return new Sedan(numberOfPassengers); } else if (type == 2) { return new Truck(numberOfPassengers); } else { throw new IllegalArgumentException("No such Car-Type"); } /** Car result = null; switch (type) { case 0: result = new Cabriolet(numberOfPassengers); break; case 1: result = new Sedan(numberOfPassengers); break; case 2: result = new Truck(numberOfPassengers); break; } return result; **/ } public int fill(double numberOfGallons) { if (numberOfGallons < 0) return -1; fuel += numberOfGallons; return 0; } public double getTripConsumption(Date date, int length, Date summerStart, Date summerEnd) { double consumption; if (date.before(summerStart) || date.after(summerEnd)) { consumption = length * winterFuelConsumption + winterWarmingUp; } else { consumption = length * summerFuelConsumption; } return consumption; } public int getNumberOfPassengersThatCanBeCarried() { if (!isDriverAvailable()) return 0; if (fuel <= 0) return 0; return numberOfPassengers; } public boolean isDriverAvailable() { return driverAvailable; } public void setDriverAvailable(boolean driverAvailable) { this.driverAvailable = driverAvailable; } public void startMoving() { if (numberOfPassengers > 0) { fastenPassengerBelts(); fastenDriverBelt(); } else { fastenDriverBelt(); } } public void fastenPassengerBelts() { } public void fastenDriverBelt() { } public int getMaxSpeed() { if (type == TRUCK) return 80; if (type == SEDAN) return 120; return 90; } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

myqms

Level 33 , Landshut, Germany

4 October 2020, 08:50

Thank you, this solved my problem.

Dave Andrea

Level 41 , Canada

3 October 2020, 12:14

solution

It is technically correct, but it is preferable to avoid "magic numbers' in your code. It wants you to use the TRUCK, SEDAN, or CABRIOLET instead of the integers they correspond to. It makes the code more readable to someone who has never seen it before.