am i not reading it line by line ?

Question about the task

Transactionality

Java Core, Level 7, Lesson 10

Under discussion

5 and 6th requirement not passing.

Make the joinData method transactional, i.e. if it fails, then the data must not be changed.
1. Read 2 file names from the console.
2. Read from the files line by line. Read from the first file into allLines, from the second file — into linesForRemoval.
In the joinData method:
3. If the allLines list contains all the lines from linesForRemoval, then remove from the allLines list all the lines that are in linesForRemoval.
4. If the condition in Item 3 is not satisfied, then:
4.1. clear the data in allLines
4.2. throw a CorruptedDataException
The joinData method should be called in main. Handle all exceptions in the main method.
Don't forget to close the streams.

Requirements:

The Solution class must contain a public static List<String> field called allLines.
The Solution class must contain a public static List<String> field called linesForRemoval.
The Solution class must have a public void joinData() method that can throw a CorruptedDataException.
The program should read the names of two files from the console.
The program must read line by line from the first file into the allLines list.
The program must read line by line from the second file into the linesForRemoval list.
The joinData method must remove from the allLines list all lines in the linesForRemoval list if allLines contains all the lines in the linesForRemoval list.
The joinData method must clear the allLines list and throw a CorruptedDataException, if allLines does not contain all the lines in the linesForRemoval list.
The joinData method should be called in main.

package com.codegym.task.task17.task1721; import java.util.ArrayList; import java.util.List; import java.io.*; /* Transactionality */ public class Solution { public static BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); public static List<String> allLines = new ArrayList<>(); public static List<String> linesForRemoval = new ArrayList<>(); public static void main(String[] args) throws CorruptedDataException{ Solution obj = new Solution(); obj.joinData(); } public void joinData() throws CorruptedDataException { String fileName1; String fileName2; String curr; String s; try{ fileName1 = reader.readLine(); fileName2= reader.readLine(); BufferedReader reader1=new BufferedReader(new InputStreamReader(new FileInputStream(fileName1))); BufferedReader reader2 = new BufferedReader(new InputStreamReader(new FileInputStream(fileName2))); while((curr = reader.readLine()) != null){ allLines.add(curr); } while((s= reader.readLine())!= null){ linesForRemoval.add(s); } reader1.close(); reader2.close(); } catch(Exception e){} for(int i=0; i<linesForRemoval.size();i++){ if(allLines.contains(linesForRemoval.get(i))){ allLines.remove(linesForRemoval.get(i)); } else{ allLines.clear(); throw new CorruptedDataException(); } } } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Misiu

Level 41 , Gdansk, Poland

5 October 2020, 19:33

reader, reader1, reader2 So which ones of them read files?

sourav bamotra

Level 20 , jammu, India

5 October 2020, 20:04

oops!! typo :/

sourav bamotra

Level 20 , jammu, India

5 October 2020, 20:07

well i changed it to reader1 and reader2 on line no 31 and 35. still not met the 5th and 6th requirement :(

Misiu

Level 41 , Gdansk, Poland

5 October 2020, 21:08

Close streams reader and reader1 as soon as possible.

sourav bamotra

Level 20 , jammu, India

6 October 2020, 09:01

updated it but still not passed it. :( am not able to paste my code here just first 5 lines are getting pasted rest is just dissappearing

try{
 BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
String fileName1 = reader.readLine();
String fileName2= reader.readLine();
reader.close();

Misiu

Level 41 , Gdansk, Poland

6 October 2020, 10:15

Try to read files that way: BufferedReader reader1=new BufferedReader(new FileReader(fileName1));