Output is correct but fails 3 tests

Question about the task

Under discussion

Can someone help figure out what's wrong?

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int n = Integer.parseInt(reader.readLine()); int max = Integer.parseInt(reader.readLine()); while(reader.readLine() != null){ if(n>=max) max = n; n = Integer.parseInt(reader.readLine()); } if(max>0) System.out.println(max); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Karas Java Developer

6 October 2020, 23:59

I rememeber, the instructions might be a litle complicated. Basically the first number you will read will be the quantity of numbers that your program has to read. for example: 3 8 7 3 The first number is three your program will read three additional numbers, in this case 8, 7 and 3. I think it reads like 5 in the exercise or more. Then use if else statements as needed and also varibles to hold and compare. My recomendations: Create 3 int variables, initialize two of them to 0 these will be your "memory" or "storage". The first buffered reader has to be out of the for loop use the not initialized variable to hold the first number. Then use that variable to set the for loop, in reverse, in other words instead of ++ do --. Inside the for loop read the next number and asign it to one of the "memories" Compare it to the other "memory" if it is mayor asign it to this other memory if not loop again. Then do final check to make sure it is not minor to 0 or 0 and print. Hopefully this helps.

Marios

Level 7 , Greece

10 October 2020, 11:05

Correct me if I am wrong, but if you do that, you will always compare the first value with the other values. What if you have the following values: 10, 20, 30, 5

Karas Java Developer

11 October 2020, 17:53

If you do not complete the loop, meaning there is no else statement, nothing happens, it just loops again, keeping the prior number and comparing it again. Just remember what is asking for: Displays the maximum of the N entered numbers. Meaning just the highest number, so if it is less that the one in memory just discard it.

sourav bamotra

Level 20 , jammu, India

6 October 2020, 08:36

i recommend you read the task conditions again :) 1. The program should read the number from the keyboard i.e you need to first initialize a bufferedreader for that. 2. The program must display a number on the screen i.e your final maximum value should be displayed on console output screen. 3. no need to explain ;) 4. no need to create any other method. 5. it means you have to read "n" numbers from keyboard and display the maximum of those number the number that you have to read from the reader should be equal to the value of n(or simply you have to read/input "n" numbers).

for(int i=0; i<n;i++){
//read the numbers here.
// add these numbers to ArrayList
}
System.out.println(Collections.max(list));

adding the number to list will make it easy to find the maximum number. 6. it says if we enter the number n and if it is less than 0 or equals to 0. Simply print nothing i.e System.out.println();