What's wrong with my code?

Question about the task

Under discussion

It seems correct to me. "Be sure that the lines list has the ADDED label with the required lines in the correct places."

Read 2 file names from the console: file1 and file2.
Both files contain text, but file2 is an updated version of file1. Some of the lines are still the same.
You need to create a merged version of the lines by writing them to the lines list.
The ADDED and REMOVED labels can't be used consecutively—they must always separated by the SAME label.
The example includes empty lines for clarity.
Neither the original file nor the updated file have empty lines!

Example 1:
original updated merged file1: file2: Result: (lines) line1 line1 SAME line1 line2 REMOVED line2 line3 line3 SAME line3 line4 REMOVED line4 line5 line5 SAME line5 line0 ADDED line0 line1 line1 SAME line1 line2 REMOVED line2 line3 line3 SAME line3 line4 ADDED line4 line5 line5 SAME line5 line0 REMOVED line0

Example 2:
original updated merged file1: file2: Result: (lines) line1 line1 SAME line1 line0 ADDED line0

In the example, empty lines mean that the line is not in the specified file.

Requirements:

The Solution class must contain a LineItem class.
The Solution class must have an enum called Type.
The Solution class must have a public static List<LineItem> field called lines that is initialized immediately.
In the main(String[] args) method, the program must read file names from the console (use BufferedReader).
In the main(String[] args) method, the BufferedReader used for reading input from the console must be closed after use.
The program must read the contents of the first and second file (use FileReader).
The file input streams (FileReader) must be closed.
The lines list should contain the merged version of the lines from the files. Each line should start with the label ADDED, REMOVED, or SAME, depending on the action taken.

package com.codegym.task.task19.task1916; import javax.sound.sampled.Line; import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Tracking changes */ public class Solution { public static List<LineItem> lines = new ArrayList<>(); public static void main(String[] args) throws IOException { BufferedReader console = new BufferedReader(new InputStreamReader(System.in)); String file1 = console.readLine(), file2 = console.readLine(); console.close(); FileReader file1Reader = new FileReader(file1), file2Reader = new FileReader(file2); List<String> file1Lines = readLines(file1Reader), file2Lines = readLines(file2Reader); mergeLines(file1Lines, file2Lines); } public static List<String> readLines(FileReader fileReader) throws IOException { BufferedReader reader = new BufferedReader(fileReader); List<String> fileLines = new ArrayList<>(); String line; while ((line = reader.readLine()) != null) { fileLines.add(line); } reader.close(); return fileLines; } public static void mergeLines(List<String> oldLines, List<String> newLines) { int indexOld = 0, indexNew = 0; while (indexOld < oldLines.size() && indexNew < newLines.size()) { String oldLine = oldLines.get(indexOld); String newLine = newLines.get(indexNew); if (oldLine.equals(newLine)) { lines.add(new LineItem(Type.SAME, oldLine)); indexOld ++; indexNew ++; } else if (indexOld + 1 < oldLines.size() && oldLines.get(indexOld + 1).equals(newLine)) { lines.add(new LineItem(Type.REMOVED, oldLine)); indexOld ++; } else if (indexNew + 1 < newLines.size() && newLines.get(indexNew + 1).equals(oldLine)) { lines.add(new LineItem(Type.ADDED, newLine)); indexNew ++; } } if (indexOld < oldLines.size()) { lines.add(new LineItem(Type.REMOVED, oldLines.get(indexOld))); } if (indexNew < newLines.size()) { lines.add(new LineItem(Type.ADDED, oldLines.get(indexNew))); } } public static enum Type { ADDED, // New line added REMOVED, // Line deleted SAME // No change } public static class LineItem { public Type type; public String line; public LineItem(Type type, String line) { this.type = type; this.line = line; } } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Dyrits

Level 22

15 October 2020, 10:06

The issue was line 57. I was using the wrong list. My updated solution:

public static List<String> readLines(FileReader fileReader) throws IOException {
    BufferedReader reader = new BufferedReader(fileReader);
    List<String> fileLines = new ArrayList<>();
    String line;
    while ((line = reader.readLine()) != null) {
        fileLines.add(line);
    }
    reader.close();
    return fileLines;
}

public static void mergeLines(List<String> oldLines, List<String> newLines) {
    Predicate<Integer> oldHasLine = index -> index < oldLines.size();
    Predicate<Integer> newHasLine = index -> index < newLines.size();
    int indexOld = 0, indexNew = 0;
    while (oldHasLine.test(indexOld) && newHasLine.test(indexNew)) {
        String oldLine = oldLines.get(indexOld);
        String newLine = newLines.get(indexNew);
        if (oldLine.equals(newLine)) {
            lines.add(new LineItem(Type.SAME, oldLine));
            indexOld ++;
            indexNew ++;
        } else if (oldHasLine.test(indexOld + 1) && oldLines.get(indexOld + 1).equals(newLine)) {
            removeLine(oldLine);
            indexOld ++;
        } else if (newHasLine.test(indexNew + 1) && newLines.get(indexNew + 1).equals(oldLine)) {
            addLine(newLine);
            indexNew ++;
        }
    }
    if (oldHasLine.test(indexOld) && !newHasLine.test(indexNew)) { removeLine(oldLines.get(indexOld)); }
    if (newHasLine.test(indexNew) && !oldHasLine.test(indexOld)) { addLine(newLines.get(indexNew)); }
}

private static void addLine(String line) { lines.add(new LineItem(Type.ADDED, line)); }
private static void removeLine(String line) { lines.add(new LineItem(Type.REMOVED, line)); }