5th condition doesn't validate

Question about the task

Resolved

I tried countless times, looked a few times in the help section, tested it with a few cases, and still it won't validate. The code handles even nested within nested within nested tags (x3). Does anyone have any suggestions or test cases I can try? Thank you very much!

Read from the console the name of a file containing HTML.

Example:
Info about Leela Leela Turanga
Supergirl

The main method's first parameter is a tag name. For example, "span".
Display all tags that match the specified tag.
The order should match their order in the file, each tag on a new line.
The number of spaces, newline characters (\n), or carriage returns (\r) does not affect the result.
The file does not have a CDATA tag. Each opening tag has a separate closing tag, and there are no self-closing tags.
Tags may have nested tags.

Example output:
Leela Turanga Leela Turanga Super girl

Tag templates:
<tag>text1</tag> <tag text2>text1</tag> <tag text2>text1</tag>

text1 and text2 can be empty

Requirements:

The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program must write to the console all the tags that match the tag specified by the argument passed to the main method.

package com.codegym.task.task19.task1918; /* Introducing tags */ import java.io.*; import java.util.ArrayList; public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String fileName = reader.readLine(); reader.close(); BufferedReader bufferedFileReader = new BufferedReader(new FileReader(fileName)); StringBuilder stringBuilder = new StringBuilder(); while (bufferedFileReader.ready()) { stringBuilder.append(bufferedFileReader.readLine()); } bufferedFileReader.close(); String fileContents = stringBuilder.toString().replaceAll("\r\n", ""); String openingTag = "<" + args[0]; String closingTag = "</" + args[0] + ">"; ArrayList<String> tags = new ArrayList<>(); while (fileContents.indexOf(openingTag) != -1) { String nestedTag2 = ""; String nestedTag3 = ""; String tag = fileContents.substring(fileContents.indexOf(openingTag), fileContents.indexOf(closingTag) + args[0].length() + 3); if (tag.indexOf(openingTag, args[0].length()) != -1) { nestedTag2 = fileContents.substring(fileContents.indexOf(openingTag), fileContents.indexOf(closingTag, fileContents.indexOf(closingTag) + args[0].length() + 1) + args[0].length() + 3); if (tag.indexOf(openingTag, tag.indexOf(openingTag, args[0].length())) != -1) { nestedTag3 = fileContents.substring(fileContents.indexOf(openingTag), fileContents.indexOf(closingTag,fileContents.indexOf(closingTag, fileContents.indexOf(closingTag) + args[0].length() + 1) + args[0].length() + 1) + args[0].length() + 3 ); tags.add(nestedTag3); tags.add(nestedTag2.substring(nestedTag2.indexOf(openingTag, nestedTag2.indexOf(openingTag) + args[0].length() + 1))); tags.add(nestedTag2.substring(nestedTag2.indexOf(openingTag, nestedTag2.indexOf(openingTag, nestedTag2.indexOf(openingTag) + args[0].length() + 1) + args[0].length() + 1), nestedTag2.indexOf(closingTag) + args[0].length() + 3)); fileContents = fileContents.substring(fileContents.indexOf(nestedTag3) + nestedTag3.length()); } else { tags.add(nestedTag2); tags.add(nestedTag2.substring(nestedTag2.indexOf(openingTag) + args[0].length() + 1, nestedTag2.indexOf(closingTag))); fileContents = fileContents.substring(fileContents.indexOf(nestedTag2) + nestedTag2.length()); } } else { tags.add(tag); fileContents = fileContents.substring(fileContents.indexOf(tag) + tag.length()); } } for (String tag: tags ) { System.out.println(tag); } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

20 October 2020, 13:58

#1 "The code handles even nested within nested within nested tags (x3)." The code should be able to handle as many nested tags as is possible. For exampe, if the file contained this: [span]1[span][span]3[span][span]5[span]6[span][span]4[span][span]2[span][span] the output would be this: [span]1[span][span]3[span][span]5[span]6[span][span]4[span][span]2[span][span] [span][span]3[span][span]5[span]6[span][span]4[span][span]2[span] [span]3[span][span]5[span]6[span][span]4[span][span] [span][span]5[span]6[span][span]4[span] [span]5[span]6[span][span] [span]6[span] (i had to replace the angle brackets with square brackets as the text box reads it as actual html code) #2 With the example file from the conditions, this code throws an exception on line 41

yehuda b

Level 23 , Beersheba, Israel

20 October 2020, 21:26

Thanks for your answer! I have to figure out how to create a more efficient algorithm I guess, I literally spent over a few hours on this one already..... Thanks again!

Guadalupe Gagnon

Level 37 , Tampa, United States

21 October 2020, 14:10

solution

I can describe how I solved this. My algorithm (the loop) would first get the next open tag and if there were none then break the loop. It then created 3 ints, one to mark the index of the starting tag, then one for the closing tag index, then a counter. It would then sequentially check the rest of the string starting at the opening tag. When it found a opening tag it would add one to the counter. When it found a closing tag it would check the counter and if it was greater than 0 remove 1 from the counter, otherwise get the index following the closing tag. It now had the correct opening and closing index and got the substring. It then would chop the string to remove the opening tag and everything prior to it. So: ↓ gets next start tag ↓check counter first Info about Leela [span xml:lang="en" lang="en"][b][span]Leela Turanga[/span] [/span] ↑+1 counter ↑-1 counter ↑closing Remove the opening tag before the start of the next loop: xml:lang="en" lang="en"][b][span]Leela Turanga[/span] [/span] ↑start index ↑ counter equal 0, this is the correct closing tag After removing the starting tag there would be no more starting tags and the loop would break.

yehuda b

Level 23 , Beersheba, Israel

21 October 2020, 19:43

It took me some time to get it, but......... GENIUS!!! now I'll try to implement it

yehuda b

Level 23 , Beersheba, Israel

25 October 2020, 11:18

FINALLY... I got it done! this is my implementation whad'ya think:

fileContents = fileContents.substring(fileContents.indexOf(openingTag));

        int indexOfCloseTag = fileContents.indexOf(closingTag);

        int count = 0;

        while (fileContents.contains(openingTag)) {
            int indexOfOpenTag = fileContents.indexOf(openingTag);
            String s = "";

            while ((s = fileContents.substring(indexOfOpenTag + 1, indexOfCloseTag)).contains(openingTag)){
                count++;
                indexOfOpenTag = s.indexOf(openingTag) + 1;
            }

            while (count != 0) {
                indexOfCloseTag = fileContents.indexOf(closingTag, indexOfCloseTag + 1);
                count--;
            }

            tags.add(fileContents.substring(fileContents.indexOf(openingTag), indexOfCloseTag) + "</" + args[0] + ">");
            try {
                fileContents = fileContents.substring(fileContents.indexOf(openingTag, 1));
            }
            catch (StringIndexOutOfBoundsException e) {
                break;
            }
            indexOfCloseTag = fileContents.indexOf(closingTag);

        }
        for (String tag : tags
        ) {
            System.out.println(tag);
        }

I had to surround the redefining of fileContents with try/catch, cause after it gets to "girl" (from the task example) the string doesn't have an opening tag so it returns -1. also I believe this algorithm wouldn't work if the file would contain [span]Leela[span]Turanga[/span][span]Faucci[/span]Something[/span] Whew! this was by far the most difficult task I had in java ever!!!!