CodeGym/Help with Java Tasks/Correct result but not passing :/

Level 41

Belgrade

27.10.2020
450views
15comments

Correct result but not passing :/

Question about the task

Iterating through a file tree

Java Collections, Level 1, Lesson 2

Archived

Can anyone tell me what I did wrong ? Because if I test I am passing...

1. The main method is passed two arguments as inputs.
The first argument is path, which is the path to the directory; the second is resultFileAbsolutePath, which is the name (full path) of an existing file that will store the result.
2. For each file in the path directory and in all of its subdirectories, do the following:
For each file whose size in bytes is NOT greater than 50, do the following:
2.1. Sort them by file name in ascending order. Don't include the path when sorting.
2.2. Rename resultFileAbsolutePath to "allFilesContent.txt" (use the FileUtils.renameFile method and FileUtils.isExist if necessary).
2.3. Sequentially write the contents of each file from step 2.1 to allFilesContent.txt. After the body of each file, write "\n".
All files have the TXT extension.
Use "/" as the path separator.

Requirements:

The file passed as the second argument to main must be renamed to allFilesContent.txt.
You need to create a stream to write to the renamed file.
The contents of every file that is 50 bytes or smaller must be written to the allFilesContent.txt file.
The output stream to the file must be closed.
Don't use static variables.

package com.codegym.task.task31.task3101; /* Iterating through a file tree */ import java.awt.*; import java.io.*; import java.util.*; import java.util.List; public class Solution { public static void main(String[] args) throws IOException { File directory = new File(args[0]); File resultFileAbsolutePath = new File(args[1]); // File directory = new File("C:\\Users\\cuksi\\Desktop\\test"); // File resultFileAbsolutePath = new File("C:\\Users\\cuksi\\Desktop\\test\\rezultat.txt"); File destination = new File(resultFileAbsolutePath.getParent() + "/allFilesContent.txt"); if (FileUtils.isExist(destination)) { FileUtils.deleteFile(destination); } FileUtils.renameFile(resultFileAbsolutePath,destination); List<String> fileList = new ArrayList<>(); for (File file : directory.listFiles()) { if (file.isDirectory()) { for (File fileSubDir : file.listFiles()) { if (fileSubDir.length() <= 50) { fileList.add(fileSubDir.getName()); } } } else { if (file.length() <= 50 && !file.getName().equals("allFilesContent.txt")) { fileList.add(file.getName()); } } } Collections.sort(fileList); StringBuilder sb = new StringBuilder(); for (String name : fileList) { sb.append(name + "\n"); } sb.setLength(sb.length()-1); FileOutputStream outputStream = new FileOutputStream(destination); outputStream.write(sb.toString().getBytes()); outputStream.close(); } }

Comments (15)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

27 October 2020, 19:37

useful

Few Things: #1 line 66 will not work for this task. Condition 2.1 says "Sort them by file name in ascending order. Don't include the path when sorting.". This code would sort alphabetically using the full path. #2 Line 42 checks if the file is a directory and then gets all the files in that directory but what if there are sub directories in that sub directories and so on? #3 it does say to rename the file variable created with arg[1] on line 18, which you do at line 33, but then you open a stream on line 79 using the variable you create on line 25. I would recommend using the renamed variable from line 18 to open the stream on line 79.

Goran

Level 41 , Belgrade, Serbia

27 October 2020, 20:48

#1 I am adding only file name to the list see command on line 58 and 48 : ileList.add(file.getName()); #2 Yes this is problem I see now, thnx. #3 Damn I wanted to do that but missed that. Thanks good eye.

Goran

Level 41 , Belgrade, Serbia

27 October 2020, 20:51

I have changed my code but still not passing:

String path = args[0];
File directory = new File(path);
File resultFileAbsolutePath = new File(args[1]);

File destination = new File(resultFileAbsolutePath.getParent() + "/allFilesContent.txt");

        if (FileUtils.isExist(destination)) {

            FileUtils.deleteFile(destination);

        }

        FileUtils.renameFile(resultFileAbsolutePath,destination);



        List<String> fileList = new ArrayList<>();

        try (FileOutputStream outputStream = new FileOutputStream(destination)) {

            fileList = getFileTree(path);

            int size = fileList.size();

            int count = 0;

            Collections.sort(fileList);

            for (String value : fileList) {

                count++;

                if (count == size) {

                    outputStream.write(value.getBytes());

                } else {

                    String temp = value + "\n";

                    outputStream.write(temp.getBytes());
                }

            }
} catch (IOException ignored) {

        }

public static List<String> getFileTree(String root) throws IOException {

        List<String> filesList = new ArrayList<>();

        Queue<File> queue = new LinkedList<>();

        File dir = new File(root);

        queue.add(dir);

        while (!queue.isEmpty()) {

            File[] arrDir = queue.poll().listFiles();

            if (arrDir != null) {

                for (File data : arrDir) {

                    if (data.isDirectory() || data.getName().equals("allFilesContent.txt")) {

                        queue.add(data);

                    } else {

                        if (data.length() <= 50) {
          filesList.add(data.getName());
                        } else {
                        }
                    }
                }
            }
        }
return filesList;
    }

Goran

Level 41 , Belgrade, Serbia

27 October 2020, 20:52

getFileTree method is outside of main method, but no room in previous post. And also hint order of tasks should be different previous task is helping a lot for solving this one.

Guadalupe Gagnon

Level 37 , Tampa, United States

27 October 2020, 21:01

useful

Ok, for point #1, I see that now. This is, however, an issue because the output should be sorted by file name but have the full file path. So, the output would look something like this: C:/LupesFiles/aaa.txt C:/LupesFiles/subDir/bbb.txt C:/LupesFiles/ccc.txt etc.. I think once you fix this it should pass Also, I like the way that you use the Queue in the getFileTree() method. I solved this task by making a similar method that used recursion instead to get all the files instead. I think your method would use less resources and process faster.

Goran

Level 41 , Belgrade, Serbia

27 October 2020, 21:21

Thanks for info, I was 100% sure I am supposed to write only file names. Hmm I did made changes, instead of List I am using now TreeMap. When I test output is correct but still not passing. I am getting error again for 3rd condition ( The contents of every file that is 50 bytes or smaller must be sorted by file name and written to the allFilesContent.txt file ) with this message: " Be sure that nothing superfluous is written to the allFilesContent.txt file. "

Goran

Level 41 , Belgrade, Serbia

27 October 2020, 21:24

Still not passing and going mad here :@

public class Solution {
    public static void main(String[] args) {

String path = args[0];
File directory = new File(path);
File resultFileAbsolutePath = new File(args[1]);

File destination = new File(resultFileAbsolutePath.getParent() + "/allFilesContent.txt");

 if (FileUtils.isExist(destination)) {

 FileUtils.deleteFile(destination);

        }

 FileUtils.renameFile(resultFileAbsolutePath,destination);


  try (FileOutputStream outputStream = new FileOutputStream(destination)) {

   Map<String, String> map = getFileTree(path);

int size = map.size();

int count = 0;


for (Map.Entry<String, String> entry : map.entrySet() ) {

                count++;

                if (count == size) {

                    outputStream.write(entry.getValue().getBytes());

                } else {

                    String temp = entry.getValue() + "\n";

                    outputStream.write(temp.getBytes());

                }

            }


        } catch (IOException ignored) {

        }

    }
    public static Map<String, String> getFileTree(String root) throws IOException {


        Map<String, String> map = new TreeMap<>();

        Queue<File> queue = new LinkedList<>();

        File dir = new File(root);

        queue.add(dir);

        while (!queue.isEmpty()) {

            File[] arrDir = queue.poll().listFiles();

            if (arrDir != null) {

                for (File data : arrDir) {

                    if (data.isDirectory()  || data.getName().equals("allFilesContent.txt")) {

                        queue.add(data);

                    } else {

                        if (data.length() <= 50) {

                            map.put(data.getName(), data.getAbsolutePath());

                        } else {

                        }

                    }

                }

            }

        }

        return

Guadalupe Gagnon

Level 37 , Tampa, United States

27 October 2020, 22:24

Last line of the conditions: "Use "/" as the path separator" The file class stores files such as: "C:\lupe\Code\examples\filename.txt"

Goran

Level 41 , Belgrade, Serbia

28 October 2020, 13:06

Yeah I saw that condition later and tried "/", but still not passing :/ Getting same error

Guadalupe Gagnon

Level 37 , Tampa, United States

28 October 2020, 13:45

=( Im sorry, I probably have been running you through some loops. I don't have my original solve on this task but after going over some other people's posts I have figured out what we have been missing: "Sequentially write the contents of each file from step 2.1 to allFilesContent.txt"

Goran

Level 41 , Belgrade, Serbia

28 October 2020, 19:30

But what they mean by that ?

Guadalupe Gagnon

Level 37 , Tampa, United States

28 October 2020, 20:05

useful

The contents, what is contained inside the file, so if I had an example file called numbers.txt ,and it contained: 1 2 3 4 5 6 7 8 Your output file should contain: 1 2 3 4 5 6 7 8 and not: numbers.txt (along with all the contents from the other files)

Goran

Level 41 , Belgrade, Serbia

30 October 2020, 10:02

I am reading file by file, and writing them down if they are fulfilling condition. When I tested first time I had result file also included but I fixed that so now it is not included. But still I fail :/

Guadalupe Gagnon

Level 37 , Tampa, United States

30 October 2020, 13:13

" and writing them down if they are fulfilling condition" You are still sorting the files/data by file name before writing the data to the output file?

Goran

Level 41 , Belgrade, Serbia

31 October 2020, 10:00

Yes I am sorting them before writing to output file. For that I am using TreeMap