Can't meet the requirements

Question about the task

Under discussion

I would be happy if anyone could help me in finding a solution. My game works fine (both in the codegym IDE and local in VS Code). I don't think my solution is that far away from decent code (correct me please if iam wrong) but I can't get Codegym to accept my solution. I have tried to different approaches, with no success. Honestly at this point, it's not about solving problems or finding a solution, but only to find code which Codegym accepts. Which sucks on so many levels. I would like to continue but iam stuck here. I would appreciate any help. Thanks a lot!

Now let's tackle the method responsible for flagging a cell. We'll call it markTile.

It must:

- mark a cell on the playing field with a flag, or remove a flag from a cell;
- track the number of flags;
- handle drawing and erasing flags on the playing field;
- change the a cell's color if a flag is being set and restore the original color if a flag is being removed.

You can set or remove a flag in the game by clicking the right mouse button. Therefore, in the MinesweeperGame class, you need to override the Game class's onMouseRightClick(int, int) method and call the markTile(int x, int y) method.

Check that everything works — run the game.

Requirements:

The MinesweeperGame class must have a private void markTile(int, int) method.
The markTile(int x, int y) method must not do anything if the element is already revealed (isOpen == true).
The markTile(int, int) method must not do anything if the number of unused flags (countFlags) is zero and the current element is not a flag (isFlag = false).
The markTile(int, int) method must set the isFlag field to true, reduce the number of unused flags by one, draw the FLAG symbol on the field if the current element is not a flag (use the setCellValue(int, int, String) method), and change the cell background on the field (use the setCellColor(int, int, Color) method). For example, to Color.YELLOW.
The markTile(int, int) method must set the isFlag field to false, increase the number of unused flags by one, draw an empty cell on the field if the current element is a flag (use the setCellValue(int, int, String) method), and change the cell background on the field (use the setCellColor(int, int, Color) method).
The MinesweeperGame class must override the Game parent class's onMouseRightClick(int, int) method.
The onMouseRightClick(int, int) method must call the markTile(int, int) method.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.Color; import com.codegym.engine.cell.Game; import java.util.ArrayList; import java.util.List; public class MinesweeperGame extends Game { private static final int SIDE = 9; private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private List<GameObject> MinesOnField = new ArrayList<>(); private int countMinesOnField = 0; private int unusedFlags = 0; private static final String MINE = "\uD83D\uDCA3"; private static final String FLAG = "\uD83D\uDEA9"; private static final Color colorCell = Color.ORANGE; private static final Color colorOpen = Color.GREEN; private static final Color colorMine = Color.RED; private static final Color colorFlag = Color.YELLOW; public void initialize() { setScreenSize(SIDE, SIDE); createGame(); } private void createGame() { boolean isMine = false; // Schleife für Zeilen for (int y = 0; y < SIDE; y++) { // Schleife für Spalten for (int x = 0; x < SIDE; x++) { isMine = getRandomNumber(10) < 1; gameField[y][x] = new GameObject(x, y, isMine); setCellColor(x, y, colorCell); if (isMine) { countMinesOnField++; MinesOnField.add(gameField[y][x]); } } } countMineNeighbors(); unusedFlags = countMinesOnField; } private List<GameObject> getNeighbors(GameObject gameObject) { List<GameObject> result = new ArrayList<>(); for (int y = gameObject.y - 1; y <= gameObject.y + 1; y++) { for (int x = gameObject.x - 1; x <= gameObject.x + 1; x++) { if (y < 0 || y >= SIDE) { continue; } if (x < 0 || x >= SIDE) { continue; } if (gameField[y][x] == gameObject) { continue; } result.add(gameField[y][x]); } } return result; } private void countMineNeighbors() { List<GameObject> result = new ArrayList<>(); for (int y = 0; y < SIDE; y++) { // Schleife für Spalten for (int x = 0; x < SIDE; x++) { if (gameField[y][x].isMine) { continue; } result = getNeighbors(gameField[y][x]); for (GameObject gameObject : result) { if (gameObject.isMine) { gameField[y][x].countMineNeighbors++; } } } } } private void openTile(int x_, int y_) { if (gameField[y_][x_].isOpen == true) { return; } if (gameField[y_][x_].isMine) { // Game Over setCellValue(x_, y_, MINE); gameField[y_][x_].isOpen = true; setCellColor(x_, y_, colorMine); } else { gameField[y_][x_].isOpen = true; setCellColor(x_, y_, colorOpen); if (gameField[y_][x_].countMineNeighbors == 0) { setCellValue(x_, y_, ""); for (GameObject neighbors : getNeighbors(gameField[y_][x_])) { openTile(neighbors.x, neighbors.y); } } else { setCellNumber(x_, y_, gameField[y_][x_].countMineNeighbors); } } } @Override public void onMouseLeftClick(int x_, int y_) { openTile(x_, y_); } @Override public void onMouseRightClick(int x_, int y_) { markTile(x_, y_); } private void markTile(int x_, int y_) { if (!gameField[y_][x_].isOpen) { if (gameField[y_][x_].isFlag) { gameField[y_][x_].isFlag = false; unusedFlags++; setCellValue(x_, y_, ""); setCellColor(x_, y_, colorCell); } else { if (unusedFlags != 0) { gameField[y_][x_].isFlag = true; unusedFlags--; setCellValue(x_, y_, FLAG); setCellColor(x_, y_, colorFlag); } } } } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Switch/Cypher

Level 25 , Bexleyheath, United Kingdom

31 October 2020, 08:20

As an example to start you off

if (tile.isOpen){
           return;
       }

       if (!tile.isFlag && countFlags == 0){
           return;
       }

This approach will make your code easier to debug.

Tobias Gion

Level 5 , Kronach, Germany

1 November 2020, 06:03

Unfortunately it still doesn't pass even the second test: The markTile(int x, int y) method must not do anything if the element is already revealed (isOpen == true).

private void markTile(int x_, int y_) {
    GameObject tile = gameField[y_][x_];

    if (tile.isOpen) {
        return;
    }

    if (!tile.isFlag && unusedFlags == 0) {
        return;
    }

    // Tile has a flag therefore remove flag
    if (tile.isFlag) {
        tile.isFlag = false;
        unusedFlags++;
        setCellValue(x_, y_,  "");
        setCellColor(x_, y_, colorCell);
    }
    // Tile has NO flag therefore add flag
    else {
        tile.isFlag = true;
        unusedFlags--;
        setCellValue(x_, y_,  FLAG);
        setCellColor(x_, y_, colorFlag);
    }
}

Switch/Cypher

Level 25 , Bexleyheath, United Kingdom

1 November 2020, 11:11

Here's mine which passed:

private void markTile(int x, int y) {
       GameObject tile = gameField[y][x];

       if (isGameStopped) {
           return;
       }
       if (tile.isOpen) {
           return;
       }

       if (!tile.isFlag && countFlags == 0) {
           return;
       }

       if (!tile.isFlag) {
           setCellValue(x, y, FLAG);
           tile.isFlag = true;
           setCellColor(x, y, Color.CYAN);
           countFlags--;
           return;
       }

       tile.isFlag = false;
       countFlags++;
       setCellValue(x, y, "");
       setCellColor(x, y, Color.ORANGE);
   }

Switch/Cypher

Level 25 , Bexleyheath, United Kingdom

1 November 2020, 11:13

useful

I think it may be because you are calling it 'UnusedFlags' not 'countFlags', The validator is very fussy about stuff like that, and, yes, I agree it makes things difficult because you need to use their names which sometimes have less meaning than the ones you would assign yourself. Also make sure you are using their:

Color.SOMECOLOR

it won't like that either.

Switch/Cypher

Level 25 , Bexleyheath, United Kingdom

31 October 2020, 08:07

Clean up the code by starting with:

GameObject tile = gamefield[y][x];

So that you only need to refer to 'tile' thereafter. Then try separating out your if statements with returns. For example - it's not an 'else' if the it's immediately a nested 'if'.

Tobias Gion

Level 5 , Kronach, Germany

1 November 2020, 05:43

Thanks for your advice and your time. Ill give it a shot.