code is not working..

Question about the task

Rule of the triangle

Java Syntax, Level 4, Lesson 4

Resolved

I think I am overlooking why this isn't working..

Use the keyboard to enter three numbers a, b, and c (the lengths of the sides of the proposed triangle).
Determine whether a triangle with these sides can exist.
Display the result as follows:
"The triangle is possible." - if a triangle with these sides could exist.
"The triangle is not possible." - if a triangle with these sides cannot exist.

Hint:
A triangle can exist only if the sum of two of its sides is greater than the third side.
You need to compare each side with the sum of the other two.
If even one side is larger or equal to the sum of the other two sides, then no such triangle exists.

Requirements:

The program should read three numbers from the keyboard.
The program should display text on the screen according to the task conditions.
If a triangle with the specified sides could exist, you need to display: "The triangle is possible."
If a triangle with the specified sides cannot exist, you need to display: "The triangle is not possible."

package com.codegym.task.task04.task0415; /* Rule of the triangle */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { InputStreamReader ISR = new InputStreamReader(System.in); BufferedReader BR = new BufferedReader(ISR); String someString = BR.readLine(); int number01=Integer.parseInt(someString); int number02=Integer.parseInt(someString); int number03=Integer.parseInt(someString); int number0102= number01 + number02; int number0203= number02 + number03; int number0103= number01 + number03; if((number0102>number03) && (number0203>number01) && (number0103>number02)) System.out.println("The triangle is possible."); else System.out.println("The triangle is not possible."); } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

26 December 2018, 00:50

Did you know that a lot of this can be combined? Anytime you initialize a variable, and then pass it to a new statement, you can skip that step and just pass everthing to the right of the = sign. Examples:

/*
InputStreamReader ISR = new InputStreamReader(System.in);
               you pass ISR to BR.
BufferedReader BR = new BufferedReader(ISR);
               Instead, combine these two lines into one
*/
BufferedReader BR = new BufferedReader(new InputStreamReader(System.in));

/*
String someString = BR.readLine();
               you pass someString(1,2,3) to these numbers, combine the step
int number01=Integer.parseInt(someString);
int number02=Integer.parseInt(someString);
int number03=Integer.parseInt(someString);
           combine this
*/
int num1=Integer.parseInt(BR.readLine());
int num2=Integer.parseInt(BR.readLine());
int num3=Integer.parseInt(BR.readLine());
//smaller variable names helps

/*
int number0102= number01 + number02;
int number0203= number02 + number03;
int number0103= number01 + number03;
          combine each of these in the if statement below
*/

if((num1+num2>num3) && (num2+num3>num1) && (num1+num3>num2))
System.out.println("The triangle is possible.");
else
System.out.println("The triangle is not possible.");

 }
}

This certainly is not "right" way, but you are progressing along and might find it helpful to type a lot less.

Guadalupe Gagnon

Level 37 , Tampa, United States

26 December 2018, 00:59

And i mean anytime you see an = sign you can pretty much use everything to the left of it in any place you use the variable name to the right, code such as this is runable:

System.out.println(Integer.parseInt(new BufferedReader(new InputStreamReader(System.in)).readLine()));

which would replace this:

InputStreamReader ISR = new InputStreamReader(System.in);
BufferedReader BR = new BufferedReader(ISR);
String someString = BR.readLine();
int number = Integer.parseInt(someString );
System.out.println(x);

Niket

Level 8 , Kolkata, India

10 January 2019, 04:52

Please share the correct approach.. thanks

William Leininger

Level 5 , Vancouver, WA, United States

10 February 2019, 18:56

thank you!

William Leininger

Level 5 , Vancouver, WA, United States

10 February 2019, 19:02

what level did it take you to understand that/use that? I can see 3/4 of it/make sense of it.

Guadalupe Gagnon

Level 37 , Tampa, United States

10 February 2019, 19:06

I dont remember. I tinker a lot with code until I understand what is going on. Then I go and apply what I have learned, fail tasks, then re-examine what I thought I knew. The best way to learn code is by doing it wrong over and over again until you get it right.

Sabine Meijran-Prins

Level 7 , Enschede, Netherlands

25 December 2018, 13:04

The problem was that I had to make more string-lines :) String someString01 = BR.readLine(); String someString02 = BR.readLine(); String someString03 = BR.readLine();