I don't know why the third condition is not satisfied

Question about the task

Maximum of four numbers

Java Syntax, Level 4, Lesson 6

Resolved

I don't see a problem here.

package com.codegym.task.task04.task0419; /* Maximum of four numbers */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); int n1 = Integer.parseInt(br.readLine()); int n2 = Integer.parseInt(br.readLine()); int n3 = Integer.parseInt(br.readLine()); int n4 = Integer.parseInt(br.readLine()); int[] array = new int[]{n1,n2,n3,n4}; int max = array[0]; for (int i =0; i<array.length-1; i++){ if (array[i]>max){ max = array[i]; } } System.out.print(max); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Dyrits

Level 22

11 November 2020, 07:48

solution

Try to remove:

array.length-1

in your loop. Just use:

array.length

Or you will not reach the last index which is array[3]. 3 < 3 ? Nope... Another thing, if you know that you will get exactly 4 numbers, you can use 4 instead of the array's length, and even read the value from the console directly in your loop without using an array to store them. Example:

int max = Integer.MIN_VALUE;
for (int loop = 0 ; loop < 4; loop ++) {
    max = Math.max(Integer.parseInt(reader.readLine()), max);
}

You can also keep your statement instead of using Math.max.