How is this not right?

Question about the task

Maximum of four numbers

Java Syntax, Level 4, Lesson 6

Resolved

I'm confused. I get the correct output but it doesn't pass the test. Can anyone help me with this?

package com.codegym.task.task04.task0419; /* Maximum of four numbers */ import java.util.*; public class Solution { public static void main(String[] args) throws Exception { Scanner scan = new Scanner(System.in); int max=0; int a = scan.nextInt(); int b = scan.nextInt(); int c = scan.nextInt(); int d = scan.nextInt(); int[] array = {a,b,c,d}; for(int k=0; k<array.length; k++) { if(array[k] > 0 && array[k] > max) max = array[k]; } System.out.println(max); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

sourav bamotra

Level 20 , jammu, India

18 November 2020, 05:43

solution

well your code will work perfectly fine if it has atleast one value>0 . -> problem arises when all the values entered is less than 0 . because initial value of variable max = 0 -> now if the input is (-1,-2,-3,-4) . the correct ans in this case should be -1. but your code will print 0. because all the values we have entered is less than 0. so our variable max never gets updated because your if statement says that update value of max only if the value >0 Solution : Consider first element of array to be max and assign its value to max

max = array[0];

now use for loop and compare each elements of array with first element stored in max.

for(int k=0; k<array.length; k++){
if(max<array[k])
max = array[k];
}

and finally print your esult.

kar-fai chow

Level 8 , Hong Kong, Hong Kong

18 November 2020, 04:32

solution

your "if" condition is wrong you are comparing each number. if there is a negative number, it shouldn't become "max" try the following 4 numbers and you'll see what i mean: 1,2,3, -9