Won't accept last requirement even though I print the right result

Question about the task

Under discussion

I get the right results, but I don't understand, why I don't fulfil the last requirement ? Can someone help me or explain? :)

1. Create a list of numbers.
2. Use the keyboard to add 10 numbers to the list.
3. Display the length of the longest sequence of repeating numbers in the list.

Example for the list 2, 4, 4, 4, 8, 8, 4, 12, 12, 14:
3

The value is 3, because the longest sequence of repeating numbers is three fours.

Requirements:

The program must display a number on the screen.
The program should read values from the keyboard.
In the main method, declare an ArrayList variable with Integer elements and immediately initialize it.
The program should add 10 numbers to the collection in accordance with the conditions.
The program should display the length of the longest sequence of repeating numbers in the list.

package com.codegym.task.task08.task0812; import java.io.*; import java.util.ArrayList; import java.util.Collections; import java.util.Scanner; /* Longest sequence */ public class Solution { public static void main(String[] args) throws IOException { ArrayList<Integer> list = new ArrayList<>(); Scanner sc = new Scanner(System.in); int highestSequenceNumber = 1; int sequenceNumber = 1; for (int i = 0; i < 10; i++) { list.add(sc.nextInt()); } Collections.sort(list); for (int i = 0; i < list.size(); i++) { if (i != list.size() - 1) { if (list.get(i).equals(list.get(i + 1))) { sequenceNumber += 1; } if (sequenceNumber > highestSequenceNumber && list.get(i) != list.get(i + 1)) { highestSequenceNumber = sequenceNumber; sequenceNumber = 1; } } if (i == list.size() - 1) { if (sequenceNumber > highestSequenceNumber) { highestSequenceNumber = sequenceNumber; } } } System.out.println(highestSequenceNumber); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Isma

Level 41 , Madrid, Spain

11 December 2020, 15:34

1) This:

if (i != list.size() - 1)

and this:

if (i == list.size() - 1)

could easily fit this way:

for (int i = 0; i < list.size() - 1; i++)

2) As Nouser said, don't sort the list. 3) That's correct

if (list.get(i).equals(list.get(i + 1))) {
         sequenceNumber += 1;
     }

but then, you should consider using an if else sequence.

Nouser

Level 36 , Germany

11 December 2020, 13:02

you're not supposed to sort the list. And even with removing the sort call the results are wrong for e.g 1,1,1,2,2,2,3,3,3,3 expected 4 result 6