what's wrong with my code?

Question about the task

Minimum of four numbers

Java Syntax, Level 2, Lesson 8

Resolved

i don't understand why the 6th task wrong could someone explain?

Write a function that computes the minimum of four numbers.
The function min(a, b, c, d) should use (call) the function min(a, b)

Hint:
You need to write the body of the two existing min functions.

Requirements:

The program should display text on the screen.
The min methods should not display text on the screen.
The main method should call min(a, b) and min(a, b, c, d).
The main method should display the result of the min methods. Each time, on a new line.
The min(a, b) method must return the minimum of the numbers a and b.
The min(a, b, c, d) method must use the min(a, b) method.
The min(a, b, c, d) method must return the minimum of the numbers a, b, c, and d.

package com.codegym.task.task02.task0217; /* Minimum of four numbers */ public class Solution { public static int min(int a, int b, int c, int d) { int min = a; if(min>=b)min = b; if(min>=c)min = c; if(min>=d)min = d; return min; } public static int min(int a, int b) { int min1; if(a<=b) min1 = a; else min1 = b; return min1; } public static void main(String[] args) throws Exception { System.out.println(min(-20, -10)); System.out.println(min(-20, -10, -30, -40)); System.out.println(min(-20, -10, -30, 40)); System.out.println(min(-40, -10, -30, 40)); } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Nouser

Level 36 , Germany

31 December 2020, 10:35

solution

you should make use of the min(int, int) method inside of the min(int, int, int, int) method something like

int minOfAB = min(a, b);
int minOfCD = min(c, d);
int min = min(minOfAB, minOFCD);

//or everything in one line
//return min(min(a, b), min(c, d));

just calling min(0,0); around line 10 would do the trick, too (I guess - the validator probably just checks if such a method call is there, not if it doing something useful).

Abdelrahman

Level 5 , Amman, Jordan

13 January 2021, 19:55

I'm on lvl 4 but I happen to come look at this and I got a question why did we do return min(min(a, b), min(c, d) and not return min cause it's already going to get the minimum by doing this int minOfAB = min(a, b); int minOfCD = min(c, d); int min = min(minOfAB, minOFCD); but when I did return min it didn't give me the same answer could I know why?

Nouser

Level 36 , Germany

13 January 2021, 20:41

public static int min(int a, int b, int c, int d) {
    return min(min(a, b), min(c, d));
}

the longer way to write this is

public static int min(int a, int b, int c, int d) {
    int minOfAB = min(a, b);
    int minOfCD = min(c, d);
    int min = min(minOfAB, minOfCD);
    return min;
}

in line 4 you can replace minOfAB with min(a, b) (compare to line2) then you have

int minOfCD = min(c, d);
int min = min(min(a, b), minOFCD);
return min;

that's still doing the same. Now replace minOfCD with min(c, d) (cause it is the same)

int min = min(min(a, b), min(c, d));
return min;

and as last step we do not return min but the expression that we assigned to min

return min(min(a, b), min(c, d));