Any ideas what is wrong?

Question about the task

CRUD

Java Core, Level 7, Lesson 10

Under discussion

Looks like my code is doing what is intended...

CrUD: Create, Update, Delete.

The program runs with one of the following sets of arguments:
-c name sex bd -u id name sex bd -d id -i id

Argument values:
name (String)
sex ("m" or "f")
bd (birth date in the following format: "04 15 1990")
-c (adds a person with the specified arguments to the end of allPeople; displays the id on the screen)
-u (updates the data of the person with the specified id)
-d (performs the logical deletion of the person with the specified id; replaces all of its data with null)
-i (displays information about the person with the specified id: name sex (m/f) bd (format Apr 15 1990))

The id corresponds to the index in the list.
All the people should be stored in allPeople.
Use Locale.ENGLISH as the second argument for SimpleDateFormat.

Example arguments:
-c Washington m "04 15 1990"

Example output for the -i argument:
Washington m Apr 15 1990

Requirements:

The Solution class must contain a public static List<Person> field called allPeople.
The Solution class must have a static block where two people are added to the allPeople list.
When you start the program with the -c argument, the program should add the person with the specified arguments to the end of the allPeople list and display the id (index).
When you run the program with the -u argument, the program must update the data of the person with the specified id in the allPeople list.
When you run the program with the -d argument, the program must perform the logical deletion the person with the specified id in the allPeople list.
When you run the program with the -i argument, the program should display the data about the person with the specified id in accordance with the format given in the task.

package com.codegym.task.task17.task1710; import java.text.ParseException; import java.text.SimpleDateFormat; import java.util.ArrayList; import java.util.Date; import java.util.List; import java.util.Locale; /* CRUD */ public class Solution { public static List<Person> allPeople = new ArrayList<>(); static String choice; static String name = ""; static Sex sex; static String date; static int mfIndex = 0; static Date birthDate; static int id; static Person person; static { allPeople.add(Person.createMale("Donald Chump", new Date())); // id=0 allPeople.add(Person.createMale("Larry Gates", new Date())); // id=1 } public static void main(String[] args) { if (args[0].equals("-d") || args[0].equals("-i")){ id = Integer.parseInt(args[1]); // assign value to the id variable if param is -d or -i } else { parseNameAndSex(args); // I parse name and sex here from args and assign it to String name because parseBD(args); // I parse birthday here } choice = args[0]; switch (choice) { case "-c": { if (sex.equals(Sex.MALE)) {person = Person.createMale(name, birthDate); allPeople.add(person);} else { person = Person.createFemale(name, birthDate); allPeople.add(person);} System.out.println(allPeople.indexOf(person)); break; } case "-u": { person = allPeople.get(id); person.setName(name); person.setSex(sex); person.setBirthDate(birthDate); break; } case "-d": { //allPeople.set(id, null); (allPeople.get(id)).setName(null); (allPeople.get(id)).setSex(null); (allPeople.get(id)).setBirthDate(null); break; } case "-i": { allPeople.get(id).getInfo(); } } } public static void parseNameAndSex(String[] params) { for (int i = 0; i < params.length; i++) { //get position and value of sex and assign value to Sex sex if (params[i].equals("m")) { sex = Sex.MALE; mfIndex = i; break; } else if (params[i].equals("f")) { sex = Sex.FEMALE; mfIndex = i; break; } } if (params[0].equals("-c")) { for (int i = 1; i < mfIndex; i++) // compose String name value using sex position :)) name += params[i] + " "; } else if (params[0].equals("-u")) { id = Integer.parseInt(params[1]); // assign value to the id variable if param is -u for (int i = 2; i < mfIndex; i++) // compose String name value using sex position :)) but shift 1 index name += params[i] + " "; // because we have id if parameter is -u } name = name.trim(); } public static void parseBD(String[] params) { date = params[mfIndex+1]; try { birthDate = new SimpleDateFormat("MM dd yyyy", Locale.ENGLISH).parse(date); } catch (ParseException e) { e.printStackTrace(); } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Nouser

Level 36 , Germany

6 January 2021, 11:25

You could try to rewrite your code partially to get rid of all the static fields that weren't there initially. At least those that you use in the create and update process. It's not good coding style and I experienced in my struggles with the validator that CodyGym punishes that every now and then. Be that as it may, use local variables where possible (and that's not my idea ;) ). The next starting point to track down the problem for me would be to rework the parseNameAndSex method. You do a lot of (error prone) coding just to update your sex field and later do an equals check once in the create method. Have a look at that method and maybe implement it to your code and see if it solves your problem. It doesn't use the static person field and neither the parseNameAndSex method (but parseBD).

public static void createPerson(String[] args) {
    //initialize some vars for easier working with the program arguments
    String name = args[1];
    String sex = args[2];
    Date birthDay = parseBD(args[3]);

    //create a local variable person and save a reference to the created Person object in it
    Person person = sex.equalsIgnoreCase("m") ? Person.createMale(name, birthDay) : Person.createFemale(name, birthDay);
    if (allPeople.add(person))
        System.out.println(allPeople.indexOf(person));
    /*
    //or try that, you even won't need to create a Person reference. Validated or me but would fail miserably in a live environment
    if (allPeople.add(sex.equalsIgnoreCase("m") ? Person.createMale(name, birthDay) : Person.createFemale(name, birthDay)));
        System.out.println(allPeople.size() - 1);
    */
}

even better here would be to return an int (the index of the list entry). But then you'd need to either return -1 if adding the person didn't work or you remove the check. And I don't know what the validator thinks of that -1

Dmitri

Level 22 , Seversk, Russia

7 January 2021, 04:00

Thank you but how do you know that name is args[1] but not args[1]+args[2]+args[3] or args[1]+agrs[2] or just args[1]?

Nouser

Level 36 , Germany

7 January 2021, 08:41

cause that was the task condition: -c name sex bd it's working similar to String split.. when you start your program with arguments, all these arguments are treated like a string, then split into parts (using space as delimiter) and saved in your main methods args array. The first argument in the line is args[0], the second args[1] etc. If an argument consist itself of severel parts delimited by spaces you put that in quotation marks like:

myprog.jar -c "John Wayne" m 05.26.1907

-c is args[0], Johne Wayne args[1] and so on

Dmitri

Level 22 , Seversk, Russia

7 January 2021, 14:02

Actually, not quite that - this is example call - -c Washington m "04 15 1990". So if there is -c Gorge Washington ... name will be args[1]+args[2]

Nouser

Level 36 , Germany

7 January 2021, 16:15

that's why you have to put the name in qutation marks when it contains a space.. see above and compare with the codegym example in the task conditions

-c name sex bd
-c Washington m "04 15 1990"

date contains spaces so it is surrounded by quot. marks and if you use smth. like your example as arguments -c Gorge Washington m date then you have not the required parameters anymore (-c name sex bd) but instead -c firstName lastName sex bd