Won't read

Question about the task

Under discussion

What's wrong with my code. It won't seem to read.

Use the keyboard to enter a positive number. Determine the number of even digits and odd digits in the entered number.
If a number is divisible by 2 without a remainder (i.e. the remainder is zero), then it is even.
And we'll increase the even digit counter (static variable even) by 1.
Otherwise, the number is odd, so we'll increase the odd digit counter (static variable odd).
Display the following message: "Even: a Odd: b", where a is the number of even digits and b is the number of odd digits.

Example for 4445:
Even: 3 Odd: 1

Requirements:

The program must read data from the keyboard.
The main method should calculate how many even digits are in the entered number and then write this number to the variable even.
The main method should calculate how many odd digits are in the entered number and then write this number to the variable odd.
The program should display text on the screen.
The displayed text must match the task conditions.

package com.codegym.task.task06.task0606; import java.io.*; /* Even and odd digits */ public class Solution { public static int even; public static int odd; public static void main(String[] args) throws IOException { //write your code here BufferedReader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); while (a > 0) { if (a % 2 = 0) {even ++; } else if (a % 2 != 0) {odd++; } } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guanting Liu

Level 16 , Springfield, United States

26 January 2021, 05:55

U didn't print any output,how can u make this task complete?U get an int variable odd,and an int variable even,then wut?U need to print your output to show the result->System.out.println(xxxx). Also,it's not asking if it is a even number or a odd number,it's asking the digit in your number. So u need to count each digit if it is odd or even.Recommend to write a helper method out of the main method to make it clearer.

remote87

Level 18 , Sofia, Bulgaria

25 January 2021, 10:14

Oh, I forgot. You can't read anything:

BufferedReader = new BufferedReader(new InputStreamReader(System.in));
int a = Integer.parseInt(reader.readLine());

reader.readLine() - where is that "reader" coming from? Get it? You didn't name your BufferReader variable:

BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));

remote87

Level 18 , Sofia, Bulgaria

25 January 2021, 10:10

useful

Hi there! You have infinite loop here:

while (a > 0)

In the body of the while loop, you have only checks, but you don't have a condition to exit the loop. You check if that number is even or odd and that's it. Your code is: while the number is larger than 0, check if it's even ( 4445 it's not even ), check if it's odd ( 4445 is odd - great ), you enter in the else if body -> variable odd is incremented by 1....no exit, ok let's go back. Is the number larger than 0, well 4445 is larger, than let's go again and so on until you have the so called stack overflow. When you use loops, especially a while loop ALWAYS check for exit condition. So, I would suggest: Why not use a variable to check each time if it's odd or even? In that variable I'll save the last digit of the given number and than I'll delete that last digit and so on, until my number is 0. Let's name that variable checker. While a > 0, so far so good ( I would use while a != 0 but that's me ). Now, how can I get the last digit of my number, hmmmm:

checker = number % 10;

4445 % 10 ( modulo division ) = the remainder of that division. Using a simple calculator in windows, 4445 / 10 = 444,5. When using the modulo division, we get that 5. The last digit is saved in our checker variable. Is 5 even or odd, the result will increment one of the variables ( even / odd ). Ok, but the given number is still 4445, we need to decrease it, in order to exit the loop some day... :) So:

number /= 10; //is the same as number = number / 10

The normal division "/" gives us the integer of the division, or 4445 / 10 = 444 and than save it to our number variable. Check in the while condition, if the number is still larger than 0, well 444 is larger, so we go on. Using the calculator 444 / 10 = 44, 4 so.. you know the rest :) Happy coding!