Error in implementation of logic outside co - java help on CodeGym

Going through the topic Constructors Wanted to implement the concept you should not put your program's logic inside a constructor. For the following I tried to Put all the logic in a separate method. printFactoryInfo(). Where I pass a CarFactory object to it as an argument. putting all the logic there, and simultaneously handle potential errors (like one involving zero years). Getting Error as as

public class CarFactory{

	String name;
	int age;
	int carsCount;

	public CarFactory(String name, int age, int carsCount){

	this.name = name;
	this.age = age;
	this.carsCount = carsCount;


}

void printFactoryInfo(String name, int age, int carsCount){

	System.out.println("Our car factory is called " +this.name);
	System.out.println("It was founded " +this.age+ " years ago");
	System.out.println("Since that time, it has produced " + this.carsCount +  " cars");
	System.out.println("On average, it produces " + (this.carsCount/this.age) + " cars per year");

}

  public static void main(String[] args) {

       //CarFactory ford = new CarFactory("Ford", 115 , 50000000);

       CarFactory ford = new CarFactory("Amigo Motors", 0 , 1000);
       ford.printFactoryInfo();
   }
}

void printFactoryInfo(){ System.out.println("Our car factory is called " +this.name); System.out.println("It was founded " +this.age+ " years ago"); System.out.println("Since that time, it has produced " + this.carsCount + " cars"); if (this.age==0){ System.out.println("Enter a vlid year"); } else if (this.age>0){ System.out.println("On average, it produces " + (this.carsCount/this.age) + " cars per year"); }

public class CarFactory{ String name; int age; int carsCount; public CarFactory(String name, int age, int carsCount){ this.name = name; this.age = age; this.carsCount = carsCount; } void printFactoryInfo(){ System.out.println("Our car factory is called " +this.name); System.out.println("It was founded " +this.age+ " years ago"); System.out.println("Since that time, it has produced " + this.carsCount + " cars"); if (this.age==0){ System.out.println("Enter a valid year"); } else if (this.age>0){ System.out.println("On average, it produces " + (this.carsCount/this.age) + " cars per year"); } } public static void main(String[] args) { //CarFactory ford = new CarFactory("Ford", 115 , 50000000); CarFactory ford = new CarFactory("Amigo Motors", 0 , 1000); ford.printFactoryInfo(); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Gellert Varga

Level 23 , Szekesfehervar, Hungary

4 February 2021, 12:56

Please help me: What is the task number? or: To which lecture is this example related? It's difficult for me to find it. I would like to read that lesson again before I answer you. ------------------------------------------------------ If in line 30 you invoke the printFactoryInfo() method without any argument, in this case in line 16 you need to declare that method also without any parameter, this way:

void printFactoryInfo() {

Dinesh

Level 7 , Delhi, India

4 February 2021, 20:08

Yes Sure, Please Refer This Link

4 February 2021, 20:43

This lesson wanted to explain: not to put anything else in the constructor, only the settings of the values of the newly created object. All other operations must be done inside other methods. Dividing by zero will of course give an error in the other methods, too. But it is the task of the programmer: never happen this case. To write a code, to write a condition that checks the variable: maybe is it equal to zero?! If yes, for example you will print out a warning to the user (and not execute the dividing.)

4 February 2021, 21:30

Please Check Is it fine this way?

4 February 2021, 21:39

You can check it, too:) Copy and run your code. I copied it, and the output is below.

OUTPUT: Our car factory is called Amigo Motors It was founded 0 years ago Since that time, it has produced 1000 cars Enter a valid year

Error in implementation of logic outside constructors (Concept)