What is wrong with my solution? Number formatting.

Question about the task

Resolved

It seems the mentor is not accepting this bit of code from me. I ran through it multiple times and can't really see the error but I have a feeling its in the replaceAll method?

@Override
       public String getPhoneNumber() {
           int countryCode = data.getCountryPhoneCode();
           int phoneNumber = data.getPhoneNumber();
           String phoneNumberString = String.valueOf(phoneNumber);
           String phoneNumberFormatted = String.format("%10d", phoneNumberString);
           String finalPhoneNumber = phoneNumberFormatted.replaceAll("(\\d{3})(\\d{3})(\\d{2})(\\d{2})", "+" + countryCode + "($1)$2-$3-$4");

           return finalPhoneNumber;
       }

Adapt IncomeData to the Customer and Contact interfaces.
The adapter class is IncomeDataAdapter.
Initialize countries before running the program. Mapping between country codes and country names:
UA Ukraine
US United States
FR France
If necessary, pad phone numbers with zeros to get 10 digits long (see the examples).
Pay attention to the format of people's first and last names.

Requirements:

The Solution class must have a public static Map<String, String> field called countries.
Initialize the countries field in a static block in the Solution class using the test data provided in the task.
The IncomeDataAdapter class must implement the Customer and Contact interfaces.
The IncomeDataAdapter class must have a private IncomeData field called data.
The IncomeDataAdapter class must have a constructor with an IncomeData parameter.
Using the hints in the interfaces' comments, implement the methods of the Customer and Contact interfaces in the IncomeDataAdapter class.

package com.codegym.task.task19.task1903; /* Adapting multiple interfaces */ import java.util.HashMap; import java.util.Map; public class Solution { public static Map<String, String> countries = new HashMap<>(); static { countries.put("UA", "Ukraine"); countries.put("US", "United States"); countries.put("FR", "France"); } public static void main(String[] args) { } public static class IncomeDataAdapter implements Customer, Contact { private IncomeData data; public IncomeDataAdapter(IncomeData data) { this.data = data; } @Override public String getName() { return data.getContactLastName() + ", " + data.getContactFirstName(); } @Override public String getPhoneNumber() { int countryCode = data.getCountryPhoneCode(); int phoneNumber = data.getPhoneNumber(); String phoneNumberString = String.valueOf(phoneNumber); String phoneNumberFormatted = String.format("%10d", phoneNumberString); String finalPhoneNumber = phoneNumberFormatted.replaceAll("(\\d{3})(\\d{3})(\\d{2})(\\d{2})", "+" + countryCode + "($1)$2-$3-$4"); return finalPhoneNumber; } @Override public String getCompanyName() { return data.getCompany(); } @Override public String getCountryName() { return countries.get(data.getCountryCode()); } } public static interface IncomeData { String getCountryCode(); // For example: US String getCompany(); // For example: CodeGym Ltd. String getContactFirstName(); // For example: John String getContactLastName(); // For example: Smith int getCountryPhoneCode(); // For example: 1 int getPhoneNumber(); // For example: 991234567 } public static interface Customer { String getCompanyName(); // For example: CodeGym Ltd. String getCountryName(); // For example: United States } public static interface Contact { String getName(); // For example: Smith, John String getPhoneNumber(); // For example: +1(099)123-45-67 } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Nouser

Level 36 , Germany

3 February 2021, 11:24

solution

%10d represents a number not a string, so just feed it the int next problem is your regex. Numbers can be up to 10 digits long but they must not, there also could be 9 digits. So adapt your regex a little to catch 9 and 10 digits with the last block not catching exactly two digits but eg. 1 and more (+ instead of {2}) Edit: that doesn't harm with the plus but you introduce a space at the beginning of the number if you have 9 digits. A trim would be needed before adding the contrycode. Or you fill up the phoneNumberFormatted String with zeros... "%010d", then you have exactly 10 digits, no whitespace and you do not need to change your regex. like:

String phoneNumberFormatted = String.format("%010d", data.getPhoneNumber());
return phoneNumberFormatted.replaceAll("(\\d{3})(\\d{3})(\\d{2})(\\d{2})", "+" + data.getCountryPhoneCode() + "($1)$2-$3-$4");

Andrei

Level 41

3 February 2021, 12:23

Ahh ok, I understand now, so it should've been %010d instead of %10d because: %010d - means add as many necessary 0es until there are 10 digits, whereas %10d - means there should be a 10 digit number, but what are the rest of the digits until 10? This is what happens when you copy paste code but you don't understand it fully 😁 Thanks!

Nouser

Level 36 , Germany

3 February 2021, 12:31

it reserves space for 10 digits. If your number is 12 digits long, it's getting squeezed into 10 digits. If it's less... so what, then it's less. The room is still reserved. If you want to fill the missing room with some character, you have to name it. No magic at all :) Your solution looks pretty much like mine, I just have the mentioned + at the end cause I started the same way, without filling up the spaces, having 9 digits etc. and looking for a way to make the regex blocks match both strings that could come in. At the end I left it the way as it was with the d+ as last match block.

Nouser

Level 36 , Germany

3 February 2021, 12:37

btw, my first way to fill up the spaces was

String pNumber = String.format("%10s", data.getPhoneNumber()).replace(" ", "0");

till I looked up the format placeholders again

Andrei

Level 41

3 February 2021, 12:39

I guess that does the job as well 😁