CodeGym/Help with Java Tasks/Verifier problems?

Level 8

San Antonio

17.02.2021
545views
11comments

Verifier problems?

Question about the task

Under discussion

I seem to be having this problem a lot. As with my other problems, the code is working and includes -1 in the sum but the verifier doesn't seem to catch it. Anyone have a solution?

Use the keyboard to enter numbers.
If the user enters -1, display the sum of all entered numbers and end the program.
-1 should be included in the sum.

Hint: one of the solutions to this problem uses the following construct:

while (true) {
    int number = read the number;
    if (check whether the number is -1)
        break;
}

Requirements:

The program should read the numbers from the keyboard.
If the user enters -1, the program should display the sum of all entered numbers and then end.
The program must calculate and display the sum of the entered numbers.
The program must use a for loop or a while loop.

package com.codegym.task.task04.task0442; /* Adding */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader (new InputStreamReader(System.in)); String sNum = reader.readLine(); String sNum1 = reader.readLine(); String sNum2 = reader.readLine(); String sNum3 = reader.readLine(); String sNum4 = reader.readLine(); int num = Integer.parseInt(sNum); int num1 = Integer.parseInt(sNum1); int num2 = Integer.parseInt(sNum2); int num3 = Integer.parseInt(sNum3); int num4 = Integer.parseInt(sNum4); while (true) { int one = num; int two = num1; int three = num2; int four = num3; int five = num4; if(one>0 && two>0 && three>0 && four>0 && five<0) System.out.println(one+two+three+four+five); break; } } }

Comments (11)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

17 February 2021, 18:35

Code certainly doesn't work, and it is an extremely bad habit to always think your code does. In this task it specifically says that the code should read numbers until the user enters -1, but this code does something completely different. It has a pattern that, each loop cycle, you have to enter 4 numbers greater than 0 followed by one number less than 0. If you enter correctly it will display the sum of those numbers. If you don't match this it wont output anything. The loop breaks either way and the code ends. The way it should work is that it should allow entries as long as the user doesn't enter -1. When the user enters -1 it should output the sum of everything that was entered. Here are some examples of inputs with the correct outputs: in = -1 out = -1 in = -2, -3, -4, -1 out = -10 in = 1, 0, -1 out = 0 in = 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, -1 out = 13

EugeneEmory

Level 8 , San Antonio, United States

18 February 2021, 18:14

So on my end, I get the correct output when I try to run the solution. It's not that I'm assuming my code works all the time. everything you just put with the in/out's already works on my end. therefore, does not help me.

Guadalupe Gagnon

Level 37 , Tampa, United States

18 February 2021, 18:23

ummm... not true. The above code doesn't output the correct thing, or anything at all, in any of my examples.

EugeneEmory

Level 8 , San Antonio, United States

18 February 2021, 18:42

Maybe check your copy/pasting. It really is a bad habit to assume your code is always right. If I put in the description that it's working for me then take note of that. because it is. If I could post a screenshot of it showing the correct output then I would. Like before, I have been changing my inputs and no matter what I change it to the program is outputting the correct sum. Keep in mind it runs fine in intelli J when I use the code there. I'm not interested in having an argument with you about whether my code is indeed working for YOU because as I said it works on my end. If you have some valuable advice on how to change the code or write it better then by all means because you're clearly a more experienced coder. But don't talk down to people when you're not even correcting anything

Guadalupe Gagnon

Level 37 , Tampa, United States

18 February 2021, 18:49

If you made changes to the code that are not reflected above, then we are talking about 2 different codes. As it stands, the code above is what I am using and it works exactly as I explained it. I wouldn't have the code you are using on your computer. So what code are you using?

Guadalupe Gagnon

Level 37 , Tampa, United States

18 February 2021, 18:52

EugeneEmory

Level 8 , San Antonio, United States

18 February 2021, 19:00

So I understand now why you are confused, we are talking about two different things.. So you can understand what I'm saying, put the code into the verifier here on the site and input any five numbers including a negative one and you will see that it will output the correct sum. I haven't changed the code, to double check myself I copied the code I have above and used it and it still worked for me. To make it simple input 1,1,1,1,-1 and you will see that it outputs 3 which is the sum.

EugeneEmory

Level 8 , San Antonio, United States

18 February 2021, 19:05

Guadalupe Gagnon

Level 37 , Tampa, United States

18 February 2021, 19:10

That is the problem with the code, it needs to not only work with 4 numbers then -1... it needs to work with infinite (up to the limit of computer memory that is) amount of numbers entered until -1 is entered. Regardless, the above code is going to need implemented devices that: a) loop an infinite amount of times, only stopping when the number entered equals -1 b) a way to save the sum of all the numbers that have been entered The task gives a really strong hint on how to do a:

while (true) {
    int number = /*read the number;*/
    if (/*check whether the number is -1*/)
        break;
}

With point b, the easiest way is to create a variable that you can continue to add each entry to as a running total. Be sure to place it in a spot within the loop that ensures that all entries are added to it, including the -1. So, some pseudo code on how that should look/work: 1| create variable for sum 2| start of loop: 3| read user input and parse to int 4| add that to the current value of sum 5| check if loop should break 6| go back to start of loop: 7| output sum

Gellert Varga

Level 23 , Szekesfehervar, Hungary

17 February 2021, 16:19

useful

The program must be able to work even if you want to enter 50 numbers, but also if you only want to enter 10 numbers. Your version only works with 5 pieces. Therefore, the data must be read within a cycle. This cycle should only end if the number entered is -1.

EugeneEmory

Level 8 , San Antonio, United States

18 February 2021, 18:16

Thank you! that clears things up a bit. What would you recommend I try? I don't want a piece of code that solves the problem but if you could help point me in the right direction of how to set it up that would be cool.