It works in IDE

Question about the task

Greater than 10? You're not a good fit for us

Java Syntax, Level 8, Lesson 8

Under discussion

last requir doesn't met. Why? It works correct in IDE

package com.codegym.task.task08.task0814; import java.util.HashSet; /* Greater than 10? You're not a good fit for us */ public class Solution { public static HashSet<Integer> createSet() { HashSet<Integer> h = new HashSet<>(); for (int i = 0; i <20 ; i++) { h.add(i); } return h; } public static HashSet<Integer> removeAllNumbersGreaterThan10(HashSet<Integer> set) { // write your code here HashSet<Integer> copy = new HashSet<>(set); for (int i = 0; i < copy.size(); i++) { if (i>10){ set.remove(i); } } return set; } public static void main(String[] args) { } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Vincenzo Seggio

Level 28

27 February 2021, 13:59

Try your code with this entries:

h.add(12);
        h.add(1);
        h.add(22);
        h.add(8);
        h.add(11);
        h.add(55);
        h.add(120);
        h.add(7);
        h.add(4);
        h.add(87);
        h.add(63);
        h.add(5);
        h.add(2);
        h.add(15);
        h.add(6);
        h.add(98);
        h.add(9);
        h.add(54);
        h.add(1225);
        h.add(41);
        h.add(124545);

You don't need the HashSet copy line 21. One possibility is use the (Hashset) removeIf - method to delete all entries bigger than 10.

Nouser

Level 36 , Germany

27 February 2021, 13:39

You can not remover from a collection when looping over it. That will throw an exception (ConcurrentModificationException). If a single thread issues a sequence of method invocations that violates the contract of an object, the object may throw this exception. For example, if a thread modifies a collection directly while it is iterating over the collection with a fail-fast iterator, the iterator will throw this exception. Such a loop is a fail-fast iterator. So you could either use a fail safe iterator. That's what I usually would recommend. As an alternative it is possible to loop over a copy and delete from the original. Or you save everything you want to modify in another container, then you use that container to loop over and delete from the target. Edit: OK, have seen that you already work with a copy ;) The problem is, that you just remove elements with values of 11 -20 from the set. Use an iterator, get the value, compare the value and in case it is > 10 delete it.