Hi everyone, why is my code fails? - java help on CodeGym

import java.io.BufferedReader; import java.io.InputStreamReader; /* Cats */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String key = "a"; while(!key.equals("")) { key = reader.readLine(); Cat cat = CatFactory.getCatByKey(key); System.out.println(cat.toString()); } } static class CatFactory { static Cat getCatByKey(String key) { Cat cat = new Cat(key); if ("feral".equals(key)) { cat = new MeanCat("Claws"); } else if ("miss".equals(key)) { cat = new NiceCat("Missy"); } else if ("smudge".equals(key)) { cat = new NiceCat("Smudgey"); } else { cat = new Cat(key); } return cat; } } static class Cat { private String name; protected Cat(String name) { this.name = name; } public String getName() { return this.name; } public String toString() { return "I'm " + getName() + ", an alley cat"; } } static class MeanCat extends Cat { MeanCat(String name) { super(name); } public String toString() { return "I'm " + getName() + ", and I'm going to claw your eyes out"; } } static class NiceCat extends Cat { NiceCat(String name) { super(name); } public String toString() { return "I'm a nice kitten named " + getName(); } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Tamas Horcsak

Level 18 , Leeds, United Kingdom

28 February 2021, 09:41

Thank you for your help but still didn't pass my other way around thinking. I checked finally the solution and surprisingly they used a switch, not if conditions in the cat factory.

Gellert Varga

Level 23 , Szekesfehervar, Hungary

28 February 2021, 20:53

I didn’t even know they solved it with 'switch'. But I solved it with if / else if / else construct and it was accepted. About your published program: When you read "Pirate" from the console, after it in the next circle of the loop the condition is still true in line 15, so it goes on and reads the empty line, and then you send that empty string to getCatByKey(), so you get an "anonymous" cat (with empty string) and you print it. - If we apply Nouser solution: while (!(key = reader.readLine()).isEmpty()) thus the reading is placed in the condition test, and if it finds an empty line, it immediately will interrupt the run and won't create "anonymous" cat.

21 April 2021, 08:03

Thank you,

Nouser

Level 36 , Germany

28 February 2021, 07:42

Have you changed the getCatByKey method? Cause it now creates with each call two objects and just one gets printed on the console (line 24 should be Cat cat = null;). If that doesn't work, try to reset the task. Your way to enter data till an emtpy string has been entered looks not really clean cause you have to initialize your key variable with some bogus value. If you do not want to go the way CG showed you, (while(true) { read...; if (no match) break;) but do already some checking inside of the while condition, then why not mpve even some more code into that condition? Like:

String key;
while(!(key = reader.readLine()).isEmpty())
    System.out.println(CatFactory.getCatByKey(key));

Now there is no need for initializing key anymore.

Thank you