Hi, whats wrong with my code ?

Question about the task

We don't need repeats

Java Syntax, Level 8, Lesson 8

Under discussion

Hi, whats wrong with my code ? It doesn't pass verification ?

Create a Map<String, String> and add ten entries that represent (last name, first name) pairs.
Remove people with the same first name.

Requirements:

The program should not display text on the screen.
The program should not read values from the keyboard.
The createMap() method must create and return a HashMap that has (String, String) elements and contains 10 entries.
The removeFirstNameDuplicates() method must remove from the map all people who have the same first name.
The removeFirstNameDuplicates() method must call the removeItemFromMapByValue() method.

package com.codegym.task.task08.task0817; import java.util.HashMap; import java.util.Map; /* We don't need repeats */ public class Solution { public static HashMap<String, String> createMap() { HashMap<String, String> map = new HashMap<>(); map.put("Stallone", "Sylvester"); map.put("Stallone2", "Bruce"); map.put("Stallone3", "Arnold"); map.put("Schwarzenegger", "Sylvester"); map.put("Schwarzenegger2", "Bruce"); map.put("Schwarzenegger3", "Arnold"); map.put("Willis", "Sylvester"); map.put("Willis2", "Bruce"); map.put("Willis3", "Arnold"); map.put("Stallone4", "Sylvester4"); return map; } public static void removeFirstNameDuplicates(Map<String, String> map) { int count = 0; HashMap<String, String> map1 = new HashMap<>(map); for (Map.Entry<String, String> x : map1.entrySet()) { for (Map.Entry<String, String> y : map1.entrySet()) { if (x.getValue().equals(y.getValue())){ count++; if (count>1){ removeItemFromMapByValue(map,x.getKey()); count--; } } } count=0; } } public static void removeItemFromMapByValue(Map<String, String> map, String value) { HashMap<String, String> copy = new HashMap<String, String>(map); for (Map.Entry<String, String> pair : copy.entrySet()) { if (pair.getValue().equals(value)) map.remove(pair.getKey()); } } public static void main(String[] args) { } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Michael

Level 10 , Dresden, Germany

14 June 2021, 14:23

The overall concept of your solution is very good. To make your code work, you should do the following: 1. Please move removeItemFromMapByValue(map,x.getKey()); in line 35 out of the inner loop because like this the iteration of the inner loop through the map.values will brake. Please do not decrement count in line 36. It is superfluous. 2. You also do not need to reset count to '0' in line 41. It is already done when the outer loop starts again (line 30).

Nouser

Level 36 , Germany

3 March 2021, 13:37

the if block from line 34 on I'd try change to so instead of decrementing the count I'd stop that iteration as you already know you need to remove all map elements with that value. And you need to change the call of removeItemFromMapByValue... it awaits a value and not a key

removeItemFromMapByValue(map,x.getValue());
count = 0;
break;