Hi, whats wrong with my code? please help

Question about the task

Robot wars

Java Core, Level 3, Lesson 11

Resolved

1. Familiarize yourself with the code.
2. Accept your fate and keep trying to understand the code.
3. ...
4. Rejoice that you've figured it out.
5. Adapt the code to the following new architecture and add new logic:
5.1. Make the AbstractRobot class abstract. Then move the attack and defend logic from the Robot class to the AbstractRobot class.
5.2. Edit the Robot class to utilize the AbstractRobot class.
5.3. Extend the BodyPart class with a new body part: BodyPart.CHEST.
5.4. Add the new body part to the implementation of the CanAttack and CanDefend interfaces (in the AbstractRobot class).

Requirements:

The AbstractRobot class must be abstract.
The AbstractRobot class must implement the CanAttack and CanDefend interfaces.
The Robot class must inherit the AbstractRobot class.
The logic defining the how a Robot behaves must be in the AbstractRobot class.
The BodyPart class must have and initialize a final static BodyPart variable called CHEST.
The new body part must be added to the logic for the attack and defend methods in the AbstractRobot class.

package com.codegym.task.task13.task1328; /* Robot wars */ public class Solution { public static void main(String[] args) { Robot amigo = new Robot("Amigo"); Robot enemy = new Robot("Enemy"); doMove(amigo, enemy); doMove(amigo, enemy); doMove(enemy, amigo); doMove(amigo, enemy); doMove(enemy, amigo); doMove(amigo, enemy); doMove(enemy, amigo); doMove(amigo, enemy); } public static void doMove(AbstractRobot robotFirst, AbstractRobot robotSecond) { BodyPart attacked = robotFirst.attack(); BodyPart defended = robotFirst.defend(); System.out.println(String.format("%%s attacked %s: its %s was attacked, and its %s was defended", robotFirst.getName(), robotSecond.getName(), attacked, defended)); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Nouser

Level 36 , Germany

4 March 2021, 16:11

line 19 will render the condition hitCount>=4 useless

Mina Nabil

Level 17 , Sydney, Australia

4 March 2021, 18:08

Still the same although I removed the hitcount, I still can't understand the hitcount logic if you could explain ? thanks. package com.codegym.task.task13.task1328; public abstract class AbstractRobot implements CanAttack,CanDefend{ private String name; private static int hitCount; public String getName() { return name; } public BodyPart attack() { BodyPart attackedBodyPart = null; hitCount = hitCount + 1; if (hitCount == 1) { attackedBodyPart = BodyPart.ARM; } else if (hitCount == 2) { attackedBodyPart = BodyPart.HEAD; } else if (hitCount == 3) { attackedBodyPart = BodyPart.LEG; } else if (hitCount>=4){ hitCount = 0; attackedBodyPart = BodyPart.CHEST; } return attackedBodyPart; } public BodyPart defend() { BodyPart defendedBodyPart = null; hitCount = hitCount + 2; if (hitCount == 1) { defendedBodyPart = BodyPart.HEAD; } else if (hitCount == 2) { defendedBodyPart = BodyPart.LEG; } else if (hitCount == 3) { defendedBodyPart = BodyPart.ARM; } else if (hitCount >= 4) { hitCount = 0; defendedBodyPart = BodyPart.CHEST; } return defendedBodyPart; } }

Nouser

Level 36 , Germany

4 March 2021, 20:35

solution

Silly me.. your Robot class must not override attack and defend you should use here the methods of the abstract call. If you do that the methods of the AbstractRobot won't get invoked when calling them on a Robot object. You would only get a null instead of a BodyPart. Also when you move now name and getName to the AbstractRobot class you should have in Robot the following as constructor (or you move back name to Robot).

public Robot(String name) {
    super(name);
}

The algorithm of the attack and defend methods are not that difficult. Each time you call attack or defend inside of the solution class (doMove() and then one attack and one defend) hitCount gets incremented by one (hitCount is static so the object it gets called on doesn't matter, means it's the same counter for amigo and enemy). Depending on the count 1 - 4+ a BodyPart gets selected and returned to the doMove method and inside the last possibility you set the count back to zero. Here you won't need a condition and just could use a simple else. That would have the same result. Finally the doMove method outputs the names of the attacker and defender and the body parts.

Mina Nabil

Level 17 , Sydney, Australia

5 March 2021, 17:53

thanks Nouser, just a quick question. I thought that if a class extends an abstract class(who implements an interface) , it has to override all th interface methods, is that right or wrong ?

Nouser

Level 36 , Germany

6 March 2021, 08:04

A class that subclasses an abstract class needs to implement all methods that have not been implemented yet (that have the abstract modifier). If there is no abstract method (all methods have an implementation), then you can but must not override these methods in a concrete class that subclasses the abstract one. If the abstract class implements an interface, then that is handled similar as if the interface methods are abstract methods inside the abstract class. So you could override them (as asked here in the task conditioins) in the abstract class or you have to override that methods in the first subclass that is not an abstract class.