Can't pass validation. I don't understand.

Question about the task

Minesweeper (Part 5/16)

Games, Level 0, Lesson 0

Resolved

Am I wrong? Or it is validator?

Minesweeper is aptly named. The player has to deal with mines, though maybe it would be best for the player to stay far away from them :)

Let's add these mines to the game. To do this, we'll adapt the GameObject class to account for the fact that a cell can be a mine (by adding the isMine flag).

Don't create a new constructor: editing the existing constructor will suffice.

Additionally, when creating the cells, add code that generates mines with a probability of 10%. The easiest way is to use the Game class's getRandomNumber(int n) method, which returns a random number from 0 to n-1 inclusive. Therefore, the probability of generating a certain number is 1/n.

And don't forget to count the number of generated mines in the MinesweeperGame class.

Once you've done all that, run the program and check that nothing is broken :)

Requirements:

The GameObject class must have a public boolean isMine field.
The GameObject class must have one constructor with (int, int, boolean) parameters that are used to initialize the x, y, and isMine fields, in that order.
There must be a private int countMinesOnField variable in the MinesweeperGame class.
When cells are created in the createGame() method, you should randomly determine whether each cell will have a mine. Use the Game class's getRandomNumber(int) method with the argument 10.
After the createGame() method is executed, the countMinesOnField variable should be assigned the value of the number of mines in the field.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; public class GameObject extends Game { public int x; public int y; public boolean isMine; public GameObject(int x, int y, boolean isMine){ this.x = x; this.y =y; this.isMine = isMine; } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

11 March 2021, 14:22

I don't see any obvious errors in the logic but I do see things in the code that shouldn't be there. Often times adding code outside the bounds of the task can cause problems with the verification. Try getting rid of lines 17-19 and get rid of 'super' on line 13 of the MinesweeperGame class.

Guadalupe Gagnon

Level 37 , Tampa, United States

11 March 2021, 14:23

I do see one more problem though. Line 35 has the variables i and j passed into the method in the wrong order.

Aleksandar Bajic

Level 13 , Banja Luka, Bosnia and Herzegovina

11 March 2021, 16:32

It works. Thanks. I comment lines 13,17,19 - and pass. It is strange that the function setScreenSize() has any effect on the verification. (On run everything works. And I think super.setScreenSize() is not wrong even with the lines 13-15)

Guadalupe Gagnon

Level 37 , Tampa, United States

11 March 2021, 17:06

It is because the verification system needs to break apart your code and individually test different aspects. This is because people can hard code values in. I bet in this particular task the verification cuts out the initialize method and then runs its own initialize, especially to ensure that it works with any value of SIDE and that you didn't hard code the screen size in your initialize. Their initialize() is going to call setScreenSize(), which is being over ridden in the code above, and that will cause errors. Now because there are literally infinite amount of mistakes that can occur, there is no way that they can reasonably tell you what is the problem. Often times, when I can't find logical errors, the next place i look is for elements of code that were added outside of the task requirements. Line 35 "works" because it does set all the cells to the starting color, but the input argument variables are still reversed. I would recommend fixing that still and be careful not to make that mistake as you progress because when the code needs to set a specific cells color, having the variable arguments backwards will do so on the wrong cell.