my code works as described

Question about the task

Archived

My code works as described in the task. What is wrong?

1. The main method is passed two arguments as inputs.
The first argument is path, which is the path to the directory; the second is resultFileAbsolutePath, which is the name (full path) of an existing file that will store the result.
2. For each file in the path directory and in all of its subdirectories, do the following:
For each file whose size in bytes is NOT greater than 50, do the following:
2.1. Sort them by file name in ascending order. Don't include the path when sorting.
2.2. Rename resultFileAbsolutePath to "allFilesContent.txt" (use the FileUtils.renameFile method and FileUtils.isExist if necessary).
2.3. Sequentially write the contents of each file from step 2.1 to allFilesContent.txt. After the body of each file, write "\n".
All files have the TXT extension.
Use "/" as the path separator.

Requirements:

The file passed as the second argument to main must be renamed to allFilesContent.txt.
You need to create a stream to write to the renamed file.
The contents of every file that is 50 bytes or smaller must be written to the allFilesContent.txt file.
The output stream to the file must be closed.
Don't use static variables.

package com.codegym.task.task31.task3101; /* Iterating through a file tree */ import java.io.*; import java.nio.file.Path; import java.nio.file.Paths; import java.util.Arrays; import java.util.Collections; import java.util.TreeSet; public class Solution { public static void main(String[] args) throws IOException { String fullName = args[0] + "/" + args[1]; // args[0] - path, args[1] - name File container = new File(fullName); //System.out.println(container); Path pathToContainer = Paths.get(container.getParent()); File newContainer = new File(pathToContainer + "/" + "allFilesContent.txt"); FileUtils.renameFile(container, newContainer); //System.out.println(newContainer); File path = new File(container.getParent()); String[] files = path.list(); //System.out.println(Arrays.toString(files)); TreeSet<String> sortedFiles = new TreeSet<>(); Collections.addAll(sortedFiles, files); FileOutputStream output = new FileOutputStream(newContainer); for (String fileName : sortedFiles) { if (fileName.equals("allFilesContent.txt")) { continue; } File file = new File(pathToContainer + "/" + fileName); if (file.length() <= 50) { FileInputStream input = new FileInputStream(file); int i=-1; while((i = input.read()) != -1) { output.write(i); //System.out.println((char) i); } output.write('\n'); output.flush(); input.close(); } } output.close(); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

allthemore

Level 41

24 March 2021, 20:02

Line#25: path.list() method returns the list of files and directories in the specified path. It doesn't give you information about files in subdirectories. You need to get all the files in subdirectories recursively and implement for them task conditions.

Dmitri

Level 22 , Seversk, Russia

30 March 2021, 10:50

public class Solution {
    public static void main(String[] args) throws IOException {
        String fullName = args[0] + "/" + args[1]; // args[0] - path, args[1] - name
        File container = new File(fullName);
        Path pathToContainer = Paths.get(container.getParent());
        File newContainer = new File(pathToContainer + "/" + "allFilesContent.txt");
        FileUtils.renameFile(container, newContainer);
        File path = new File(newContainer.getParent());
        File[] files = path.listFiles();
        List<File> allFiles = new ArrayList<>();
        getAllFiles(allFiles, files);
        FileOutputStream output = new FileOutputStream(newContainer);
        sortFiles(allFiles);
        //System.out.println(allFiles);
        for (File file : allFiles) {
            if (file.equals(newContainer)) {
                continue;
            }
            if (file.length() <= 50) {
                FileInputStream input = new FileInputStream(file);
                int i=-1;
                while((i = input.read()) != -1) {
                    output.write(i);
                    //System.out.println((char) i);
                }
                output.write('\n');
                output.flush();
                input.close();
            }
        }
        output.close();
    }

    private static void sortFiles(List<File> allFiles) {
        for (int i = 0; i < allFiles.size(); i++) {
            for (int j = i + 1; j < allFiles.size(); j++) {
                if (allFiles.get(i).getName().compareTo(allFiles.get(j).getName()) > 0) {
                    File temp = allFiles.get(i);
                    allFiles.set(i, allFiles.get(j));
                    allFiles.set(j, temp);
                }
            }
        }
    }

Dmitri

Level 22 , Seversk, Russia

30 March 2021, 10:51

private static void getAllFiles(List<File> allFiles, File[] files) {
        for (File file : files) {
            if (file.isDirectory()) {
                File[] names = file.listFiles();
                getAllFiles(allFiles, names);
            } else {
                allFiles.add(file);
            }
        }
    }

Dmitri

Level 22 , Seversk, Russia

30 March 2021, 10:52

ok, I have done that, but it did not help

allthemore

Level 41

18 May 2021, 16:18

I'm not sure about line#3: String fullName = args[0] + "/" + args[1]; According to task conditions: args[0] -- path to the directory args[1] -- resultFileAbsolutePath, which is the name (full path) of an existing file that will store the result. Looks like you are adding two full paths in the third line. Not seem to be what you are aiming for. And what if you don't write your own method for sorting files and use Collections.sort(foundFiles) instead? Try to check if the file exists with FileUtils.isExist method before renaming it.Try to test your code when resultFileAbsolutePath points to a non-existing file.