Getting correct output but task 2 and 3 not passing?

Question about the task

Under discussion

package com.codegym.task.task14.task1411;

import java.io.BufferedReader;
import java.io.InputStreamReader;

/*
User, loser, coder and programmer

*/

public class Solution {
    public static void main(String[] args) throws Exception {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        Person person = null;
        String key = null;

        // Here's the loop for reading the keys. Item 1
        while (true)
        {
            // Create an object. Item 2
            key = reader.readLine();
            switch(key)
            {
                case "user":
                    person = new Person.User();
                    doWork(person); // Call doWork
                    // break;
                case "loser":
                    person = new Person.Loser();
                    doWork(person);
                    // break;
                case "coder":
                    person = new Person.Coder();
                    doWork(person);
                    // break;
                case "programmer":
                    person = new Person.Programmer();
                    doWork(person);
                    // break;
                default:
                    break;
            }
            if (!key.equals("user") || !key.equals("loser") || !key.equals("coder") || !key.equals("programmer"))
            {
                break;
            }
        }
    }

    public static void doWork(Person person) {
        // Item 3
        if (person instanceof Person.User) ((Person.User)person).live();
        else if (person instanceof Person.Loser) ((Person.Loser)person).doNothing();
        else if (person instanceof Person.Coder) ((Person.Coder)person).writeCode();
        else if (person instanceof Person.Programmer) ((Person.Programmer)person).enjoy();
    }
}

1. Enter a few strings (keys) from the keyboard [in a loop].
The following strings (keys) are allowed: "user", "loser", "coder", "programmer".
Stop reading in strings after reading in any string that does not match one of the above.

2. For each entered string:
2.1. Create the appropriate object [see Person.java], e.g. create a User object for the string "user".
2.2. Pass this object to the doWork method.

3. Write an implementation of the doWork method, which:
3.1. Calls the live() method on the passed object if person is a User.
3.2. Calls the doNothing() method if person is a Loser.
3.3. Calls the writeCode() method if person is a Coder.
3.4. Calls the enjoy() method if person is a Programmer.

Requirements:

The main method must read strings from the keyboard.
The main method should stop reading strings from the keyboard as soon as the entered string does not match one of the allowed strings ("user", "loser", "coder", "programmer").
For each correctly entered string ("user", "loser", "coder", "programmer"), call the doWork method with the appropriate Person object as the argument.
The Solution class must implement a doWork method with one Person parameter.
The doWork method should call the live() method on the passed object if it is a User.
The doWork method should call the doNothing() method on the passed object if it is a Loser.
The doWork method should call the writeCode() method on the passed object if it is a Coder.
The doWork method should call the enjoy() method on the passed object if it is a Programmer.

package com.codegym.task.task14.task1411; import java.io.BufferedReader; import java.io.InputStreamReader; /* User, loser, coder and programmer */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); Person person = null; String key = null; // Here's the loop for reading the keys. Item 1 while (true) { // Create an object. Item 2 key = reader.readLine(); switch(key) { case "user": person = new Person.User(); doWork(person); // Call doWork // break; case "loser": person = new Person.Loser(); doWork(person); // break; case "coder": person = new Person.Coder(); doWork(person); // break; case "programmer": person = new Person.Programmer(); doWork(person); // break; default: break; } if (!key.equals("user") || !key.equals("loser") || !key.equals("coder") || !key.equals("programmer")) { break; } } } public static void doWork(Person person) { // Item 3 if (person instanceof Person.User) ((Person.User)person).live(); else if (person instanceof Person.Loser) ((Person.Loser)person).doNothing(); else if (person instanceof Person.Coder) ((Person.Coder)person).writeCode(); else if (person instanceof Person.Programmer) ((Person.Programmer)person).enjoy(); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

17 May 2021, 07:32

First readd the break statements. The problem is you if condition in line 43. Either get rid of it entirely with using a label and break to that label in line 41. Or you fix that condition by changing or to and or removing the not operator in front of every part and then surrond the remaing conditons with paranthesis and then readd the not operator before the paranthesis

if (!(key.equals("user") || key.equals("loser")))

I'd go for the label

inputLoop:
while (true)
{
    key = reader.readLine();
    switch(key)
    {
        case "user":
            doWork(new Person.User());
            break;
        // the rest here
        default:
            break inputLoop;
    }
}

or make use of the person variable

inputLoop:
while (true)
{
    key = reader.readLine();
    switch(key)
    {
        case "user":
            person = new Person.User();
            break;
        // the rest here
        default:
            break inputLoop;
    }
    doWork(person);
}