help me check the output please

Question about the task

Resolved

I didn't pass the sixth condition, and I can't check the output by myself, please help me

1. In a static block, initialize map with (number, word) pairs from 0 to 12 inclusive.
For example, (0, "zero"), (1, "one"), (2, "two")
2. Read the file name from the console, and then read the contents of the file.
3. Use map to replace all of the numbers with words.
4. Display the result.
5. Close the streams.

Example file data:
This costs 1 dollar, but this is 12. The variable is called file1. 110 is a number.

Example console output:
This costs one dollar, but this is twelve. The variable is called file1. 110 is a number.

Requirements:

The Solution class must have a public static Map<Integer, String> field called words that is initialized immediately.
The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program should write all of the lines from the file to the console, but any numbers must be replaced with the corresponding words in map.
The Solution class must have a static block that adds thirteen pairs to map.

package com.codegym.task.task19.task1924; import java.util.HashMap; import java.util.Map; import java.io.*; import java.util.*; /* Replacing numbers */ public class Solution { public static Map<Integer, String> map = new HashMap<Integer, String>(); static { map.put(0, "zero"); map.put(1, "one"); map.put(2, "two"); map.put(3, "three"); map.put(4, "four"); map.put(5, "five"); map.put(6, "six"); map.put(7, "seven"); map.put(8, "eight"); map.put(9, "nine"); map.put(10, "ten"); map.put(11, "eleven"); map.put(12, "twelve"); } public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); BufferedReader br = new BufferedReader(new FileReader(reader.readLine())); reader.close(); while (br.ready()) { String line = br.readLine(); StringBuilder res = new StringBuilder(); for (String str : line.split("\\s")) { for (String s : str.split("\\s+|(?=[.,])")) { try { int i = Integer.parseInt(s); if (i >= 0 && i <= 12) res.append(map.get(i)); else res.append(s); } catch (NumberFormatException e) { res.append(s); } } res.append(" "); } System.out.println(res.toString().trim()); } br.close(); } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

14 July 2021, 08:46

try to use your lookahead not only on ., but an all interpunctation like

for (String str : line.split("\\s+")) {
    for (String s : str.split("(?=\\p{Punct})")) {

in case CG uses a different map in its validator you also could do smth like

res.append(map.getOrDefault(Integer.parseInt(s), s));

as replacement for your try blocks content. It appends the value for the key or, if the key doesn't exist a default (here s again). That way the map could get easily enhanced without further code changes.

Evgen

Level 23

14 July 2021, 09:06

thanks again, man, separating by all punctuation marks really solve the problem, I was worried that "-" mark could be in the middle of the word... and about map.getOrDefault - it's really much more elegant)

Thomas

Level 41 , Bayreuth, Germany

14 July 2021, 09:09

my pleasure ;) and as a sidenote, if you already use lookaheads you could use them on space as well and get rid of one split loop

for (String s : line.split("(?=\\s+)|(?=\\p{Punct})")) {
    try {
        res.append(map.getOrDefault(Integer.parseInt(s), s));
    } catch (NumberFormatException e) {
        res.append(s);
    }
}

Edit: ahh, I see, then a space remains at the number and it can't parse them anymore without a trim and if you do that the space is missing in the end... As said before... I like your solutions ;)