need help

Question about the task

Under discussion

I test my code different words and arrays and get correct output, but the last condition is still unreached

1. We have a two-dimensional array that contains lowercase letters.
2. The detectAllWords method must find all the words in the wordSearch array.
3. The element(startX, startY) must correspond to the first letter of the word, while the element(endX, endY) corresponds to the last letter.
text is the word itself, located between the start and end elements
4. All the words are in the array.
5. The words can be arranged horizontally, vertically, and diagonally, both forward and backward.
6. The main method is not tested.

Requirements:

The Solution class must have a detectAllWords method.
The Solution class must contain a static Word class.
The Solution class must not have static fields.
The detectAllWords method must be static.
The detectAllWords method must be public.
The detectAllWords method should return the list of all words in the word search (according to the task conditions).

package com.codegym.task.task20.task2027; import java.util.List; import java.util.ArrayList; /* Word search */ public class Solution { public static void main(String[] args) { int[][] wordSearch = new int[][]{ {'f', 'd', 'e', 'r', 'l', 'k'}, {'u', 's', 'a', 'm', 'e', 'o'}, {'l', 'n', 'g', 'r', 'o', 'v'}, {'m', 'l', 'p', 'r', 'r', 'h'}, {'p', 'o', 'e', 'e', 'j', 'j'} }; detectAllWords(wordSearch, "home", "same"); /* Expected result home - (5, 3) - (2, 0) same - (1, 1) - (4, 1) */ } public static List<Word> detectAllWords(int[][] wordSearch, String... words) { List<Word> list = new ArrayList<>(); int count = 0; for (String word : words) { list.add(new Word(word)); char[] chars = word.toCharArray(); for (int i = 0; i < wordSearch.length; i++) { for (int j = 0; j < wordSearch[0].length; j++) { int index = 0; int y; int x; if (wordSearch[i][j] == (int)chars[index]) { list.get(count).setStartPoint(j, i); y = i; x = j; while (index < chars.length - 1) { if (x + 1 < wordSearch[0].length) { x++; index++; if (wordSearch[y][x] != (int)chars[index]) { x = j; index = 0; break; } } else { x = j; index = 0; break; } list.get(count).setEndPoint(x, y); } while (index < chars.length - 1) { if (x - 1 >= 0) { x--; index++; if (wordSearch[y][x] != (int)chars[index]) { x = j; index = 0; break; } } else { x = j; index = 0; break; } list.get(count).setEndPoint(x, y); } while (index < chars.length - 1) { if (y - 1 >= 0) { y--; index++; if (wordSearch[y][x] != (int)chars[index]) { y = i; index = 0; break; } } else { y = i; index = 0; break; } list.get(count).setEndPoint(x, y); } while (index < chars.length - 1) { if (y + 1 < wordSearch.length) { y++; index++; if (wordSearch[y][x] != (int)chars[index]) { y = i; index = 0; break; } } else { y = i; index = 0; break; } list.get(count).setEndPoint(x, y); } while (index < chars.length - 1) { if (x + 1 < wordSearch[0].length && y + 1 < wordSearch.length) { y++; x++; index++; if (wordSearch[y][x] != (int)chars[index]) { y = i; x = j; index = 0; break; } } else { y = i; x = j; index = 0; break; } list.get(count).setEndPoint(x, y); } while (index < chars.length - 1) { if (x - 1 >= 0 && y + 1 < wordSearch.length) { y++; x--; index++; if (wordSearch[y][x] != (int)chars[index]) { y = i; x = j; index = 0; break; } } else { y = i; x = j; index = 0; break; } list.get(count).setEndPoint(x, y); } while (index < chars.length - 1) { if (x - 1 >= 0 && y - 1 >= 0) { y--; x--; index++; if (wordSearch[y][x] != (int)chars[index]) { y = i; x = j; index = 0; break; } } else { y = i; x = j; index = 0; break; } list.get(count).setEndPoint(x, y); } while (index < chars.length - 1) { if (x + 1 < wordSearch[0].length && y - 1 >= 0) { y--; x++; index++; if (wordSearch[y][x] != (int)chars[index]) { y = i; x = j; index = 0; break; } } else { y = i; x = j; index = 0; break; } list.get(count).setEndPoint(x, y); } } } } count++; } return list; } public static class Word { private String text; private int startX; private int startY; private int endX; private int endY; public Word(String text) { this.text = text; } public void setStartPoint(int i, int j) { startX = i; startY = j; } public void setEndPoint(int i, int j) { endX = i; endY = j; } @Override public String toString() { return String.format("%s - (%d, %d) - (%d, %d)", text, startX, startY, endX, endY); } } }

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

27 July 2021, 15:54

I rested your code with this and got very strange results:

public static void main(String[] args) {
   int[][] wordSearch = new int[][]{
      {'f', 'd', 'e', 'r', 'l', 'k'},
      {'u', 's', 'a', 'm', 'e', 'o'},
      {'l', 'n', 'g', 'r', 'o', 'v'},
      {'m', 'l', 'p', 'r', 'r', 'h'},
      {'p', 'o', 'e', 'e', 'j', 'j'}
   };
   System.out.println(detectAllWords(wordSearch, "abba"));
}

The word "abba" is not in the search area but it output that it found it. I also put "abba" in the search area to test it and it didn't output the correct coordinates.

Evgen

Level 23

28 July 2021, 08:49

int[][] wordSearch = new int[][]{ {'f', 'd', 'e', 'r', 'l', 'k'}, {'u', 's', 'a', 'm', 'e', 'o'}, {'l', 'n', 'g', 'r', 'o', 'v'}, {'m', 'l', 'p', 'r', 'r', 'h'}, {'p', 'o', 'e', 'e', 'j', 'j'} }; for (Word w : detectAllWords(wordSearch, "abba", "gr", "boom", "home", "same")) { System.out.println(w); } After a few addings I got that output: gr - (2, 2) - (3, 2) home - (5, 3) - (2, 0) same - (1, 1) - (4, 1) Still didn't pass the last condition. The only thing I suspect to be wrong is "gr" word, there are 2 variants: horizontal and diagonal, should I output both of them? I don't get it from the task description.

Guadalupe Gagnon

Level 37 , Tampa, United States

28 July 2021, 13:22

The code I wrote that passed this task only output one. Even if I put multiple words of the same word in the search field, it still stops at the very first one it encounters. For example:

public static void main(String[] args) {
   int[][] wordSearch = new int[][]{
      {'p', 'o', 't', 'r', 'l', 'k'},
      {'p', 'o', 't', 'm', 'e', 'o'},
      {'p', 'o', 't', 'r', 'o', 'v'},
      {'p', 'o', 't', 'r', 'r', 'h'},
      {'p', 'o', 't', 'r', 'j', 'j'}
   };
   for (Word w : detectAllWords(wordSearch, "pot"))
      System.out.println(w);
}

This output: pot - (0, 0) - (2, 2)

Evgen

Level 23

28 July 2021, 16:48

hm... maybe the order in which the directions are checked matters? for example if your code check horizontal first the output will be pot - (0, 0) - (2, 0) can you tell me your check order please?

Guadalupe Gagnon

Level 37 , Tampa, United States

28 July 2021, 17:13

Mine checks in this order: 1 diagonal backwards down 2 down 3 diagonal forwards down 4 forwards So, using that grid, when it starts at 0,0 the order of checking would be

...........{  'p'  , '/*4*/', 't', 'r', 'l', 'k'},
      /*1*/{'/*2*/', '/*3*/', 't', 'm', 'e', 'o'},
           {  'p'  ,   'o'  , 't', 'r', 'o', 'v'},
           {  'p'  ,   'o'  , 't', 'r', 'r', 'h'},
           {  'p'  ,   'o'  , 't', 'r', 'j', 'j'}

So my code found "pot" on the third check

Evgen

Level 23

29 July 2021, 12:16

i give up, have no idea what can be wrong here

Guadalupe Gagnon

Level 37 , Tampa, United States

29 July 2021, 13:45

I can explain what my code does: Starting from 0,0 it checks each index in order [0,0 - 0,1 - 0,2 - 0,3 - etc]. At each index it checks if you can get the word in one of the 4 directions I specified above. It checks if the word exists either forward or backwards. What i mean is if the word was "the" it checks for both "the" and "eht". In this way it only needs to logically check those 4 directions. For each word, once it finds the very first occurrence of a particular word it stops searching for that one. It's fairly simple step by step procedures at that point.

Evgen

Level 23

8 August 2021, 15:09

my code does the same and the only differ is that mine code takes the last occurrence of the word instead of very first