What's Wrong In The Code?

Question about the task

Longest string

Java Syntax, Level 7, Lesson 6

Under discussion

I Got The Desired Output: Grandfather Grandmother Still Two Condition Are Not Fulfilled.

1. Initialize the list of strings.
2. Read 5 strings from the keyboard and add them to this list.
3. Using a loop, find the longest string in the list.
4. Display the string. If there is more than one, display each on a new line.

Requirements:

In the main method, initialize the Solution class's existing strings field to a new ArrayList<>.
The program should read 5 strings from the keyboard and write them to the list of strings.
The program should display the longest string.
If several strings qualify as the longest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0708; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Longest string */ public class Solution { private static List<String> strings; public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String s; strings = new ArrayList<String>(); //ArrayList<String> list = new ArrayList<String>(); int index = 0; for(int i=0; i<5; i++){ s = reader.readLine(); strings.add(s); } for(int i=0; i<5; i++){ if(strings.get(i).length() >= index){ index = strings.get(i).length(); System.out.println(strings.get(i)); } } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Ricardo

Level 10

29 August 2021, 22:35

You need to create a variable with the max length, you can compute this max length while you are reading your string s (After line 26). Then you need to loop through all the list checking if the length is equal to the max (line 30), and if it is equal then print it.

Lisa

Level 41

28 August 2021, 14:24

I tested your code and contrary to what you said it does not work properly for me, oh no.. oh no, no, noooo. This is so sad. But try it out yourself with the 5 strings I've tested. 1 22 333 4444 55555 This should give you an idea of where the problem is. Hint: It won't work to find the max and output it in one loop (see the above, in the first iteration 1 has the max length and gets printed but as you clearly can see, it is not the string with the max length, nooooo, oh noo - this needs fixing, fixing...) I drive crazy again, crazy, crazy 🤪😜

Shashikant Sharma

Level 8 , Surat, India

29 August 2021, 08:06

I Got Stuck Like Never Before. There's No Going Back. My Program Is Useless If You Enter The Strings in Ascending Order. It Works Absolutely Fine in Descending Order.What Should I Do Now?

public class Solution {
    private static List<String> strings;

    public static void main(String[] args) throws Exception {
        //write your code here
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        String s;
        strings = new ArrayList<String>();
        //ArrayList<String> list = new ArrayList<String>();
        int index = 0;
        String longestString = null;
        for(int i=0; i<5; i++){
            s = reader.readLine();
            strings.add(s);
        }
        for(int i=0; i<5; i++){

            if(strings.get(i).length() >= index){
                index = strings.get(i).length();
                longestString = strings.get(i);

            }
            else{
                break;
            }
            System.out.println(longestString);
        }

    }
}

Lisa

Level 41

29 August 2021, 17:06

I will quote myself: It won't work to find the max and output it in one loop Therefore I would suggest to determine the maximum length on input (or if you do not like that, then in a separate loop) and in another loop the longest string is output (if (someObject.length == maximumLength)) -> output someObject easy that way I bet that is, easy or crazy 😜🤪 ... you decide

Gellert Varga

Level 23 , Szekesfehervar, Hungary

29 August 2021, 20:25

I.) Let's take the second shared programme. with this input list: 1111 22 333333 44444444 5555555555 Please run it!! You should see this output: 1111 But this is incorrect. Why? The 'for' loop between lines 16 and 27 makes the following when checking the second element: the length of the second element ("22") is not greater than or equal to the length of the 'index' variable (i.e. the length of the previous element) so the 'else' block is invoked: break. So you exit the loop. You don't even check the other elements any further. The program think it found the maximum. But you only found one element that is smaller than the previous one. But the third and fourth and fifth elements would have been much longer than the first and second. But you didn't examine them anymore. II) Line 26 prints all the elements tested. Since there are no conditions before it, it prints the values in all rounds of the loop. However, which element should be printed will only be known AFTER you have checked ALL the elements, even the last one.