Hm, not working for first and third conditions

Question about the task

Resolved

My results when the code is run: Smith:Start game Jones:Start game Gates:Start game Gates:Gather resources Smith:Gather resources Gates:Grow economy Gates:Kill enemies Gates:won! Jones:lost Smith:lost One thing I wasn't sure if is if we're supposed to sleep before a line is printed or after, but it doesn't seem to work either way.

Three people play the game. Each player (Gamer) is characterized by two parameters: last name (name) and the actions-per-second (rating).
Display the actions taken and determine the winner and the losers.
Let's begin...
1. Figure out what the program does.
1.1. List<String> actions stores the sequence of actions performed by each player from 0 to the last.
1.2. isWinnerFound indicates whether the winner has been found.
1.3. The sleep method throws an InterruptedException and takes a long argument.
1.4. The players play independently of each other.
2. Implement the run method so that for each player:
2.1. At regular intervals (1000ms/rating), the actions specified in the actions list are displayed.
2.2. All text begins with the player's name (getName()), followed by a colon, and then the text itself.

Example:[Smith:Game start].

2.3. When a player has performed all of the actions in the actions list, he or she wins. Display [getName() + ":won!"].
2.4. When the winner is found, the game ends, and the remaining players have lost. For these players, display [getName() + ":lost"].

Don't display the square brackets ("[]").

Requirements:

At regular intervals (1000ms/rating), the Gamer class's run method should display the player's last name (getName()), followed by a colon, and then the text in OnlineGame.actions. Example: [Smith:Game start].
When all the game actions have been completed and the winner has not yet been found, the run method must set the flag OnlineGame.isWinnerFound to true (to inform the others that it is the winner).
If a player wins, his or her run method should display [getName() + ":won!"]. For example: [Jones:won!].
The run methods of all players who did not win (those who were interrupted) should display [getName() + ":lost"]. For example: [Gates:lost]
The run method must not throw an exception when it is interrupted.

package com.codegym.task.task16.task1627; import java.util.ArrayList; import java.util.List; public class Solution { public static void main(String[] args) throws InterruptedException { OnlineGame onlineGame = new OnlineGame(); onlineGame.start(); } public static class OnlineGame extends Thread { public static volatile boolean isWinnerFound = false; public static List<String> actions = new ArrayList<>(); static { actions.add("Start game"); actions.add("Gather resources"); actions.add("Grow economy"); actions.add("Kill enemies"); } protected Gamer gamer1 = new Gamer("Smith", 3); protected Gamer gamer2 = new Gamer("Jones", 1); protected Gamer gamer3 = new Gamer("Gates", 5); public void run() { gamer1.start(); gamer2.start(); gamer3.start(); while (!isWinnerFound) { } gamer1.interrupt(); gamer2.interrupt(); gamer3.interrupt(); } } public static class Gamer extends Thread { private int rating; private int stage; public Gamer(String name, int rating) { super(name); this.rating = rating; this.stage = 0; } @Override public void run() { while(true) { try { System.out.println(Thread.currentThread().getName() + ":" + OnlineGame.actions.get(this.stage)); this.stage++; if(this.stage == 4 && !OnlineGame.isWinnerFound) { OnlineGame.isWinnerFound = true; System.out.println(Thread.currentThread().getName() + ":won!"); return; } Thread.sleep(1000 / this.rating); } catch (InterruptedException e) { System.out.println(Thread.currentThread().getName() + ":lost"); return; } } } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

14 September 2021, 06:54

solution

First of all, I don't know what the validator is complaining about but I would try to move the sleep call to the top of the try block. Then a few comments to your code... if you have a variable (stage), increase its value and check that value for an abort condition, then that is a classic loop. And here you want to loop over the actions list. If you use a for-each loop the coding becomes moch more easy. My second hint could make the readibility better, too. Gamer is extending Thread so each Gamer object is of type Thread and can use Thread methods. Means inside the Gamer class you can reference the current object using this and that would be the same as getting the reference using the static Thread method Thread.currentThread(). Means you just could write this.getName() or just getName() If you'd code inside a Runnable then that'll be different. Here you'd better save the reference once inside a Thread variable cause invoking Thread.currentThread() is somewhat expensive.

Justin Smith

Level 41 , Greenfield, USA, United States

14 September 2021, 15:42

I implemented all three suggestions and it passed. The reason I didn't use a for loop originally is that, had this been a more fully functional program, you would want a getter method for the gamer object to return which "stage" it was in at any given time, and to do that you would need a variable to store that value. It seemed like better practice to do it that way. The conditions weren't clear if they wanted it to sleep before or after doing anything else. I had assumed it was after because with it before, "Jones" never even gets a start message before the program finishes. But apparently that was the intent.

Thomas

Level 41 , Bayreuth, Germany

14 September 2021, 16:12

Good point. And you still can do that using a for-each loop. Just save the reference to the current action in a variable and return that reference with your getter. When to sleep isn't clear to me either. I just did a try-fail in all these tasks when I wasn't sure.