How to make it faster? - java help on CodeGym

On my device, the snake game seems to stutter. Maybe it is too slow(it is quite old). I guess the problem is the print method? (not quite sure, though) I tried to make the print method run faster but I am not quite satisfied yet. The way I am iterating through the snake's body is bugging me, I guess this take a long time. But I can't really figure out a better way to do so. Maybe you have better ideas? I appreciate your help.

public void print() {
        StringBuilder builder = new StringBuilder();

        for(int y = 0; y < height; y++){
            builder.append("\n");
            for(int x = 0; x < width; x++){

                //I don't like this part:
                boolean body = false;
                for(int i = 1; i < snake.getSections().size(); i++){
                    if(snake.getSections().get(i).getY() == y && snake.getSections().get(i).getX() == x){
                        body = true;
                    }
                }
                //

                if(y == snake.getY() && x == snake.getX()){
                    builder.append("X");
                }
                else if(body == true){
                    builder.append("x");
                }
                else if(y == mouse.getY() && x == mouse.getX()){
                    builder.append("^");
                }
                else{
                    builder.append(".");
                }
            }
        }
        System.out.println(builder);

public void print() { StringBuilder builder = new StringBuilder(); for(int y = 0; y < height; y++){ inner: for(int x = 0; x < width; x++){ if(y == snake.getY() && x == snake.getX()){ builder.append("X"); continue inner; } else { for(int i = 1; i < snake.getSections().size(); i++){ if(snake.getSections().get(i).getY() == y && snake.getSections().get(i).getX() == x){ builder.append("x"); continue inner; } } } if(y == mouse.getY() && x == mouse.getX()) builder.append("^"); else{ builder.append("."); } } builder.append("\n"); } System.out.println(builder); }

// add a field for the board String board = "Build the board on initialization to save so you wont have to re-build it each time print it called"; public void print() { StringBuilder builder = new StringBuilder(board); int x = 0; // add mouse // first find the proper line by the mouse's Y value for(int i = 0; i < mouse.getY(); i++) // this gets the index of each line break, searching from the spot of the previous one x = builder.indexOf("\n", x) + 1; // adds the mouse's X value to the current index x = x + mouse.getX(); // replaces the char at the index specified with the correct char builder.replace(x, x + 1, "^"); x= 0; // add snake head for(int i = 0; i < snake.getY(); i++) x = builder.indexOf("\n", x) + 1; x = x + snake.getX(); builder.replace(x, x + 1, "X"); // add each snake piece for(int i = 1; i < snake.getSections().size(); i++){ x = 0; SnakeSection sec = snake.getSections().get(i); for(int j = 0; j < sec.getY(); j++) x = builder.indexOf("\n", x) + 1; x = x + sec.getX(); builder.replace(x, x + 1, "x"); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

12 October 2021, 13:33

useful

This should speed it up:

However, since in most cases the period '.' char is going to be printed the most, there are a lot of if statements that have to be failed before it reaches the point to add a period. A better way would be to first create the board and then place the snake and mouse on the board.

12 October 2021, 13:43

solution

something like this:

I didn't debug this code, so it may not work properly, but you can use it as a guide and get it working. This should work the fastest for you.

Jurij Thmsn

Level 29 , Flensburg, Germany

13 October 2021, 08:15

Thanks a lot for taking the time! Building the board first and then just actualize the snake etc is so much smarter. I will try to make it work. Right now I am also trying to make a little GUI for the snake game and convert it to an .exe so i can run it on my desktop. Thanks again!

13 October 2021, 13:07

Nice idea