Hm, my solution is not working

Question about the task

Resolved

public void save(OutputStream outputStream) throws Exception
{
    PrintWriter writer = new PrintWriter(outputStream);
    writer.println(this.name);
    writer.println(this.assets.size());
    if(this.assets.size() > 0)
    {
        for(int i = 0; i < this.assets.size(); i++)
        {
            writer.println(this.assets.get(i).getName());
            writer.println(this.assets.get(i).getPrice());
        }
    }
}

public void load(InputStream inputStream) throws Exception
{
    int numAssets = 0;
    BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
    this.name = reader.readLine();
    numAssets = Integer.parseInt(reader.readLine());
    if(numAssets > 0)
    {
        for(int i = 0; i < numAssets; i++)
        {
            this.assets.add(new Asset(reader.readLine(), Double.parseDouble(reader.readLine())));
        }
    }
}

I think I've accounted for everything.The conditions specifically say that name is never empty, so you don't need a check for that I'm assuming (meaning I don't need something similar to isNamePresent from the previous lesson). I store the number of assets in the file, and then loop based on that number to read/write the asset values. Replacing writer.println with System.out.println, it appears that it should be writing the data correctly. Anyway, the first two conditions aren't validating. Looking to get an idea what I'm not doing correctly.

Implement the logic for file IO for the Human class.
The Human class's name field can't be empty.
The main method exists just for you and is not involved in testing the solution.

Requirements:

The read/write logic in the save/load methods must work correctly when the assets list is empty.
The read/write logic in the save/load methods must work correctly when the name field and assets list are not empty.
The Solution.Human class should not support the Serializable interface.
The Solution.Human class must be public.
The Solution.Human class should not support the Externalizable interface.

package com.codegym.task.task20.task2001; import java.io.*; import java.util.ArrayList; import java.util.Arrays; import java.util.List; /* Reading and writing to a file: Human */ public class Solution { public static void main(String[] args) { // Update the string passed to the createTempFile method based on the path to a file on your hard drive try { File yourFile = File.createTempFile("your_file_name", null); OutputStream outputStream = new FileOutputStream(yourFile); InputStream inputStream = new FileInputStream(yourFile); Human smith = new Human("Smith", new Asset("home", 999_999.99), new Asset("car", 2999.99)); smith.save(outputStream); outputStream.flush(); Human somePerson = new Human(); somePerson.load(inputStream); inputStream.close(); // Check that smith is equal to somePerson } catch (IOException e) { // e.printStackTrace(); System.out.println("Oops, something is wrong with my file"); } catch (Exception e) { // e.printStackTrace(); System.out.println("Oops, something is wrong with the save/load method"); } } public static class Human { public String name; public List<Asset> assets = new ArrayList<>(); public Human() { } public Human(String name, Asset... assets) { this.name = name; if (assets != null) { this.assets.addAll(Arrays.asList(assets)); } } @Override public boolean equals(Object o) { if (this == o) return true; if (o == null || getClass() != o.getClass()) return false; Human human = (Human) o; if (name != null ? !name.equals(human.name) : human.name != null) return false; return assets != null ? assets.equals(human.assets) : human.assets == null; } @Override public int hashCode() { int result = name != null ? name.hashCode() : 0; result = 31 * result + (assets != null ? assets.hashCode() : 0); return result; } public void save(OutputStream outputStream) throws Exception { PrintWriter writer = new PrintWriter(outputStream); writer.println(this.name); writer.println(this.assets.size()); if(this.assets.size() > 0) { for(int i = 0; i < this.assets.size(); i++) { writer.println(this.assets.get(i).getName()); writer.println(this.assets.get(i).getPrice()); } } } public void load(InputStream inputStream) throws Exception { int numAssets = 0; BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream)); this.name = reader.readLine(); numAssets = Integer.parseInt(reader.readLine()); if(numAssets > 0) { for(int i = 0; i < numAssets; i++) { this.assets.add(new Asset(reader.readLine(), Double.parseDouble(reader.readLine()))); } } } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

15 November 2021, 20:26

I'm not 100% sure, as your code seems to work fine for me. Try removing lines 85 and 86 (along with the closing bracket) and the subsequent lines in the load method that use numAssets. You don't need this. In the save method nothing will be written in the loop if the size is 0. In the load method you can either use the .ready() method of the BufferedReader class to find out if there is more data, or just continue reading until you get a null. (personally the .ready() method is the better OOP way of doing it)

Justin Smith

Level 41 , Greenfield, USA, United States

15 November 2021, 20:31

So it turned out to be really simple. I just forgot to close the writer and reader objects at the end of each method. All I changed was that and it worked.

Guadalupe Gagnon

Level 37 , Tampa, United States

15 November 2021, 20:38

That is really strange because a stream should only ever be closed in the method that it was declared in, in this task both streams were created in main. Closing it in another method can cause problems. Anyways, since you passed I wouldn't worry too much about it, the validation system can be wonky.

Justin Smith

Level 41 , Greenfield, USA, United States

15 November 2021, 20:47

I didn't close the InputStream or OutputStream (which, as you mention, were declared in the Main method). Just the PrintWriter and BufferedReader.