countMineNeighbors () est un problème

Question about the task

Under discussion

Bien le bonjour! Quelqu'un peut m'éclairer sur mon erreur ? Je n'arrive pas a faire rouler la méthode countMineNeighbors (). Ca compile bien mais la task ne veut pas se valider... Merci d'avance :)

Now let's count the mines in adjacent cells. To do this, we'll add a field to each cell of the matrix, which will be responsible for the number of mined neighbors. First, we find all the neighbors, and then we count how many of them are mined.

To get the list of neighbors, you now have the getNeighbors() method, which has one GameObject (cell) parameter.

Your task is to, in a separate method, count the number of mined neighbors for each cell in gameField and assign this value to the appropriate field of the cell.

Although your work is not visible (you started program to see what happens, right?), it is very important to future steps.

Requirements:

The GameObject class must have a public int countMineNeighbors field.
The MinesweeperGame class must have a private void countMineNeighbors() method.
The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field.
The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method.
In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; public class MinesweeperGame extends Game { private static final int SIDE = 9; private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private int countMinesOnField; public void initialize (){ setScreenSize (SIDE, SIDE); createGame(); } private void createGame() { for (int y = 0; y < SIDE; y++){ for(int x=0; x < SIDE; x++) { boolean isMine = getRandomNumber(10) < 1 ? true : false; if (isMine) { countMinesOnField++; } gameField[y][x] = new GameObject (x, y, isMine); setCellColor (x, y, Color.ORANGE); } } countMineNeighbors(); } private ArrayList<GameObject> getNeighbors (GameObject gameObject) { ArrayList <GameObject> neighbors = new ArrayList<>(); for (int y = gameObject.y - 1; y <= gameObject.y +1; y++) { for (int x = gameObject.x - 1; x <= gameObject.x + 1; x++){ if (x <0 || x > SIDE) { continue; } if (y < 0 || y > SIDE){ continue; } if (x == gameObject.x && y == gameObject.y) { continue; } neighbors.add(gameField[y][x]); } } return neighbors; } private void countMineNeighbors () { for (int y = 0; y < SIDE; y++){ for(int x=0; x < SIDE; x++) { if (!gameField[y][x].isMine) { int count = 0; for (GameObject o : getNeighbors(gameField[y][x])){ if (o.isMine){ count++; } } gameField[y][x].countMineNeighbors = count; } } } } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Lisa

Level 41

19 December 2021, 10:00

lines 38 and 41 will cause an outOfBounds exception if you access the matrix using values validated that method. Rmember, SIDE is the length of the array and the length isn't an index of the array. x > SIDE however will allow the length of the array to be a valid index.