How did I get here?

Question about the task

Under discussion

My program seems to fulfill all the requirements, it recursively creates and displays 15 threads following the listed instruction. Yet if you notice the test requirements, my program is still failing. Any help would be appreciated.

1. Change the GenerateThread class to make it a thread.
2. Create a GenerateThread constructor, which must:
2.1. Call the superclass's constructor, passing the created thread's number as a String. Use createdThreadCount.
2.2. Start the current thread.
2.3. The thread numbers must start with 1.
3. Override the toString method: inside GenerateThread, use Alt+Insert -> Override Methods. Start typing "toString".
3.1. The toString method must return the current thread number and the word "created". Use getName().

Example:
8 created

4. If the number of created threads is less than Solution.count, the run method must:
4.1. Create a new GenerateThread.
4.2. Display the thread created in Item 4.1.
5. In the end, 15 lines should be output to the console.

Requirements:

The GenerateThread class should inherit the Thread class.
The GenerateThread class must have a public no-argument constructor.
The GenerateThread class constructor should increment createdThreadCount and pass it as a string to the superclass constructor.
The GenerateThread class constructor must start the thread.
The GenerateThread class's toString method must return the thread name and the word " created". Example: "8 created".
If the number of created threads is less than Solution.count, the run method must create a new GenerateThread.
If the number of created threads is less than Solution.count, the run method must display the created thread.
The program's output must match the task conditions and indicate that all 15 threads have been created.

package com.codegym.task.task16.task1623; /* Creating threads recursively */ public class Solution { static int count = 15; static volatile int createdThreadCount = 0; public static void main(String[] args) { System.out.println(new GenerateThread()); } public static class GenerateThread extends Thread { public GenerateThread() { super(String.valueOf(++createdThreadCount)); start(); if (createdThreadCount < count) { System.out.println(new GenerateThread()); } } @Override public String toString() { return getName() + " created"; } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

matemate123

Level 50 , Kraków, Poland

9 January 2023, 17:21

First of all you need override and implement run() method in your GenerateThread class. "the run method must: 4.1. Create a new GenerateThread. 4.2. Display the thread created in Item 4.1." You have body for this method allready done in other place in your code. It's tricky task but combine a little and you can do it. You are really close to positive verification. If in toString() overriding method will be problem too, try a little combine with first element in return method.

Karas Backend Developer

6 January 2022, 01:46

I suggest you change the ++createdThreadCount the other way around createdThreadCount++, otherwise is doing something before something else and also is like you sum up something that should not.

Lisa

Level 41

3 January 2022, 13:47

I think CG doesn't think you would code business logic into the constructor as this is considered bad practice. That's probably why validation fails. The even gave you the hint that there needs to be a run method where you should create new threads and display threads. That's better than a good bunch of other tasks where you need to guess what they are expecting from you 😬