please where is the error in my code last two conditions are not satisfied

Question about the task

Under discussion

manually when i compile it ,code seems to fine ,where is the mistake

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); ArrayList<String> list = new ArrayList<String>(); int lng=0; int shrt=0; for(int i=0;i<10;i++){ String s = reader.readLine(); list.add(s); } String temp =list.get(0); for(int j=1;j<5;j++){ if(list.get(j).length()<temp.length()){ temp=list.get(j); shrt=j; } } String temp1=list.get(0); for(int j=1;j<5;j++){ if(list.get(j).length()>temp1.length()){ temp1=list.get(j); lng=j; } if(shrt<lng){ System.out.println(list.get(shrt)); } else System.out.println(list.get(lng)); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

23 January 2019, 15:48

I did not modify any of your existing code, I just added sys.out statements in it so that the output can help you figure out the problem. Copy and paste this code into lines 23 - 69:

for(int i=0;i<10;i++){
            list.add(tempt[i]);
        }
        String temp =list.get(0);
        System.out.println("Checking for shortest. Initial value of temp: '" + temp + "'");

        for(int j=1;j<5;j++){
            System.out.print("Loop cycle: " + j + " - ");
            System.out.print("Is '" + list.get(j) + "' shorter than '" + temp +"'? " +(list.get(j).length()<temp.length()));
            if(list.get(j).length()<temp.length()){
                temp=list.get(j);
                shrt=j;

            }
            System.out.println(list.get(j).length()<temp.length()?" temp set to '" + temp : "' index at " + shrt);
        }

        String temp1=list.get(0);
        System.out.println("Checking for longest. Initial value of temp1: '" + temp1 + "'");
        for(int j=1;j<5;j++){
            System.out.print("Loop cycle: " + j + " - ");
            System.out.print("Is '" + list.get(j) + "' greater than '" + temp +"'? " +(list.get(j).length()>temp1.length()));
            if(list.get(j).length()>temp1.length()){
                temp1=list.get(j);
                lng=j;
            }
            System.out.println(list.get(j).length()>temp1.length()?" temp1 set to '" + temp : "' index at " + lng);
            if(shrt<lng)
                System.out.println(list.get(shrt));
            else
                System.out.println(list.get(lng));

        }

srikanth

Level 10 , Bangalore, India

24 January 2019, 07:39

dude cheers one silly mistake i did was (j<5 actually it is j<10) your solution helped me to figure it out thank you so much at last executed.

Guadalupe Gagnon

Level 37 , Tampa, United States

24 January 2019, 14:41

My pleasure. I like to show people how I solve problems in code. Start putting sys.out statements throughout your code to get checks on what it is doing. You will probably use it very sloppily at first, at least i did, but practice makes perfect. I started doing this around your level and it made solving these a lot more easily achievable. Good luck with the levels!