Why is 3rd condition not passing?

Question about the task

Under discussion

I've looked at other questions and tried to correct the code in ways that were suggest by those and it is not passing, still. public List<FileProperties> getFileList() throws Exception { if (!Files.isRegularFile(zipFile)) throw new NoSuchZipFileException(); List<FileProperties> files = new ArrayList<>(); try (ZipInputStream zipInputStream = new ZipInputStream(Files.newInputStream(zipFile))) { ZipEntry zipEntry; while ((zipEntry = zipInputStream.getNextEntry()) != null) { ByteArrayOutputStream baos = new ByteArrayOutputStream(); copyData(zipInputStream, baos); files.add(new FileProperties(zipEntry.getName(), zipEntry.getSize(), zipEntry.getCompressedSize(), zipEntry.getMethod())); } zipInputStream.closeEntry(); } return files; }

Let's continue to move toward getting the contents of an archive. Let's write a getFileList() method inside the ZipFileManager class. It will return a list of the files in the archive, or rather a list of the properties of these files (we already implemented the FileProperties class).
Let's begin:
1. Add a List<FileProperties> getFileList() throws Exception method to the ZipFileManager class.
2. Inside that method, check whether zipFile is a regular file using a suitable method from the Files class. If it is not a file, throw a NoSuchZipFileException.
3. Create a list of FileProperties objects. We'll add the file properties to it.
4. Create a ZipInputStream for the file represented by the zipFile variable. As we've done before, wrap the creation of this object in a try-with-resources.
5. Go through all of the ZipEntries in the ZipInputStream
6. For each ZipEntry, read its contents (otherwise, we won't have information about its size). You can't find the size of a file in an archive without reading it. This is super easy to do using the copyData method and a temporary ByteArrayOutputStream buffer.
7. Get the name, size, compressed size, and compression method of the zip entry. Take a look at what else you can learn about the entry.
8. Create a FileProperties object using the obtained file data.
9. Add the object created in step 8 to the list from step 3.
10. Return the gathered information to the method that called the getFileList method.

Requirements:

You need to create a public List<FileProperties> getFileList() throws Exception method in the ZipFileManager class.
If Path zipFile is not a file, then the getFileList method should throw a NoSuchZipFileException.
The getFileList method should go through all of the archive's files and return data about them. The method must be implemented according to the task conditions.
The stream used to read from the archive must be closed.

package com.codegym.task.task31.task3110; import com.codegym.task.task31.task3110.exception.NoSuchZipFileException; import java.io.IOException; public class Archiver { public static void main(String[] args) throws IOException { Operation operation = null; do { try { operation = askOperation(); CommandExecutor.execute(operation); } catch (NoSuchZipFileException e) { ConsoleHelper.writeMessage("You didn't select an archive or you selected an invalid file."); } catch (Exception e) { ConsoleHelper.writeMessage("An error occurred. Please check the entered data."); } } while (operation != Operation.EXIT); } public static Operation askOperation() throws IOException { ConsoleHelper.writeMessage(""); ConsoleHelper.writeMessage("Select an operation:"); ConsoleHelper.writeMessage(String.format("\t %d - Zip files into an archive", Operation.CREATE.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Add a file to an archive", Operation.ADD.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Remove a file from an archive", Operation.REMOVE.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Extract an archive", Operation.EXTRACT.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - View the contents of an archive", Operation.CONTENT.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Exit", Operation.EXIT.ordinal())); return Operation.values()[ConsoleHelper.readInt()]; } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Level 41 , Wilson, United States

13 May 2022, 22:41

I've tried a few different implementations but no validation. Can someone just sent what they used to pass since its just about it being picky?

Guadalupe Gagnon

Level 37 , Tampa, United States

14 May 2022, 00:28

done

Level 41 , Wilson, United States

13 May 2022, 16:20

Thanks, you all. It hasn't validated yet but I did have different code. I've altered it and copied some from others in the comments when mine didn't work. I removed the closeEntry method and kept it the same but as for now, it's not verifying still. public List<FileProperties> getFileList() throws Exception { if (!Files.isRegularFile(zipFile)) throw new NoSuchZipFileException(); List<FileProperties> files = new ArrayList<>(); try (ZipInputStream zipInputStream = new ZipInputStream(Files.newInputStream(zipFile))) { ZipEntry zipEntry; while ((zipEntry = zipInputStream.getNextEntry()) != null) { ByteArrayOutputStream baos = new ByteArrayOutputStream(); copyData(zipInputStream, baos); files.add(new FileProperties(zipEntry.getName(), zipEntry.getSize(), zipEntry.getCompressedSize(), zipEntry.getMethod())); } } return files; }

Lisa L

Level 47 , Nuremberg, Germany

13 May 2022, 06:08

Seems to me as if validation here is super picky. Cause of that I didn't try a lot of things and followed their instructions and till line 63 my solution looks like yours. Here I opened a ByteArrayOutputStream without try-with-resources cause they didn't mention it (contrary to the ZipInputStream) and it is of no use (there's no need to close a ByteArrayOutputStream - its close method is empty). The last ZipEntry you're closing... there's no need (but of course it doesn't harm either) . closeEntry pretty much just skips to the end of the ZipInputStreams internal buffer if not already reached. Just important when you open a new ZipEntry. But here getNextEntry does the close operation for you before it starts taking care of the next entry. The rest looks like what I have. I took the baos size, you the one saved in the ZipEntry object. But that does not matter at all (imho). One of my zip tasks in the collections quest is still open. I've tried numerous ways and they all worked. Lupe helped a lot and we both didn't find the problem. I'll try in a few days again...

Guadalupe Gagnon

Level 37 , Tampa, United States

13 May 2022, 15:16

My guess would be that line 69 is causing the problem as the loop on line 62 continues as long as the new ZipEntry being considered is not null. This will result in a 100% chance of a null pointer exception being thrown on the problem line. @J Other than that the code you submitted looks like it should pass the task. If not, the thing I do when I failed a task with code I was fairly sure passed is that I would start changing things around and try revalidating it. Everything Lisa suggested is what I would also try.

Guadalupe Gagnon

Level 37 , Tampa, United States

13 May 2022, 15:18

@Lisa I am humbled when you mention me as a source of help. You are a rock start on this platform and, when I get a chance to see your solutions, I love your coding style and logic.

Lisa L

Level 47 , Nuremberg, Germany

13 May 2022, 16:09

uhhuhhhu, blush 😊😊😊😊😊 🥳