Task conditions are too vague to know why my solution doesn't work

Question about the task

Cat carnage (3)

Java Syntax, Level 10, Lesson 2

Under discussion

The task conditions are too vague to understand why my solution doesn't work =\

Implement the boolean fight(Cat anotherCat) method: think up a mechanism for cat fighting depending on their weight, age, and strength.
Compare each attribute separately so that the winner is the one with the best performance in regards to the most attributes.

The method should determine whether the current cat (this) wins the fight or not, i.e. return true if the current cat wins and false if it loses.
If the fight is a draw and no one wins, then return false.

Requirements:

The Cat class must have only four fields: name, age, weight, and strength. The fields must be private.
The Cat class must have a fight method.
In the fight method, implement the mechanism for feline combat based on their weight, age, and strength in accordance with the task conditions.
The method should return the same value whenever the same cats fight.
If a certain cat1 wins over cat2, then cat2 must lose to cat1.
If there is a tie, then the fight method should return false.

package en.codegym.task.jdk13.task05.task0501; /* Cat carnage (1) */ public class Solution { public static void main(String[] args) { Cat cat1 = new Cat("cat1", 1, 10, 5); Cat cat2 = new Cat("cat2", 1, 10, 5); Cat cat3 = new Cat("cat3", 1, 10, 5); } public static class Cat { //write your code here private String name; private int age; private int weight; private int strength; public Cat(String name, int age, int weight, int strength) { this.name = name; this.age = age; this.weight = weight; this.strength = strength; } public boolean fight(Cat cat2) { int cat1points = 0; int cat2points = 0; //youngest cat gets a point if (this.age < cat2.age) cat1points++; else if (this.age > cat2.age) cat2points++; //heaviest cat gets a point if (this.weight > cat2.weight) cat1points++; else if (this.weight < cat2.weight) cat2points++; //strongest cat gets a point if (this.strength > cat2.strength) cat1points++; else if (this.strength < cat2.strength) cat2points++; //returns false if there's a tie if (cat1points > cat2points) return true; else return false; } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

30 May 2022, 13:38

Take this as an example:

public static void main(String[] args) {
        // new cat(name, age, weight, strength)

        // similar ages but different weight and strength
        Cat cat1 = new Cat("cat1", 1, 10, 5);
        Cat cat2 = new Cat("cat2", 1, 5, 10);
        System.out.println(cat1.fight(cat2)); // false
        System.out.println(cat2.fight(cat1)); // false

        // cat4 should clearly win this battle:
        Cat cat3 = new Cat("cat3", 5, 10, 1);
        Cat cat4 = new Cat("cat4", 6, 10, 500);
        System.out.println(cat3.fight(cat4));  // false
        System.out.println(cat4.fight(cat3));  // also false???
}

I have made cats that have similar yet different stats. In each of these examples the code should determine a winner, however this is not the case. When testing the code here with the code in your solution the result is: false false false false Because the cats all have different stats, a winner should be able to be determined. To emphasize this I even made cat3 and cat4 very similar in age and weight with cat4 being a godly in Strength compared to cat3, however when they fight (either way) it still returns false.

Guadalupe Gagnon

Level 37 , Tampa, United States

30 May 2022, 13:44

The way that I passed this code is that I ranked each stat (age, str, wght) in order of what I thought was the most to least important in a fight. Starting with the most important stat I tested each of the cat's respective skill in that stat and returned true/false depending on if one stat was higher than the other. If the stats were the same then I moved to the next important stat and repeated the same test. And if those were the same I moved to the least important stat and repeated the test. If that one was still the same then I returned false: So:

fight(cat2) {

   if(skill1 > cat2.skill1) true
   if(skill1 < cat2.skill1) false

   if(skill2 > cat2.skill2) true
   if(skill2 < cat2.skill2) false

   if(skill3 > cat2.skill3) true
   false
}