The code works correctly, but still rejected because of the last requirement !

Question about the task

Resolved

Hi everyone, The code seems working correctly, I got the same expected results for the two examples, but the code is still rejected by the validator, can any one please tell me the reason behind that ? thanks a lot. Recommendation from the mentor Be sure that the lines list has the SAME label with the required lines in the correct places.

Read 2 file names from the console: file1 and file2.
Both files contain text, but file2 is an updated version of file1. Some of the lines are still the same.
You need to create a merged version of the lines by writing them to the lines list.
The ADDED and REMOVED labels can't be used consecutively—they must always separated by the SAME label.
The example includes empty lines for clarity.
Neither the original file nor the updated file have empty lines!

Example 1:
original updated merged file1: file2: Result: (lines) line1 line1 SAME line1 line2 REMOVED line2 line3 line3 SAME line3 line4 REMOVED line4 line5 line5 SAME line5 line0 ADDED line0 line1 line1 SAME line1 line2 REMOVED line2 line3 line3 SAME line3 line4 ADDED line4 line5 line5 SAME line5 line0 REMOVED line0

Example 2:
original updated merged file1: file2: Result: (lines) line1 line1 SAME line1 line0 ADDED line0

In the example, empty lines mean that the line is not in the specified file.

Requirements:

The Solution class must contain a LineItem class.
The Solution class must have an enum called Type.
The Solution class must have a public static List<LineItem> field called lines that is initialized immediately.
In the main(String[] args) method, the program must read file names from the console (use BufferedReader).
In the main(String[] args) method, the BufferedReader used for reading input from the console must be closed after use.
The program must read the contents of the first and second file (use FileReader).
The file input streams (FileReader) must be closed.
The lines list should contain the merged version of the lines from the files. Each line should start with the label ADDED, REMOVED, or SAME, depending on the action taken.

package com.codegym.task.task19.task1916; import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.io.InputStreamReader; import java.nio.BufferOverflowException; import java.util.ArrayList; import java.util.List; /* Tracking changes */ public class Solution { public static List<LineItem> lines = new ArrayList<>(); public static void main(String[] args) throws IOException { BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(System.in)); String original = bufferedReader.readLine(); String updated = bufferedReader.readLine(); bufferedReader.close(); BufferedReader fileReaderOriginal = new BufferedReader(new FileReader(original)); BufferedReader fileReaderUpdated = new BufferedReader( new FileReader(updated)); String lineOriginal = fileReaderOriginal.readLine(); String lineUpdated = fileReaderUpdated.readLine(); while (lineOriginal != null && lineUpdated != null) { if (lineOriginal.trim().compareTo(lineUpdated.trim()) < 0) { lines.add(new LineItem(Type.REMOVED,lineOriginal)); lineOriginal = fileReaderOriginal.readLine(); } else if (lineOriginal.trim().compareTo(lineUpdated.trim()) > 0) { lines.add(new LineItem(Type.ADDED,lineUpdated)); lineUpdated = fileReaderUpdated.readLine(); } else { lines.add(new LineItem(Type.SAME,lineOriginal)); lineOriginal = fileReaderOriginal.readLine(); lineUpdated = fileReaderUpdated.readLine(); } } while (lineOriginal != null) { lines.add(new LineItem(Type.REMOVED,lineOriginal)); lineOriginal = fileReaderOriginal.readLine(); } while (lineUpdated != null) { lines.add(new LineItem(Type.ADDED,lineUpdated)); lineUpdated = fileReaderUpdated.readLine(); } fileReaderOriginal.close(); fileReaderUpdated.close(); //for (int i = 0; i < lines.size(); i++ ) // System.out.println(lines.get(i).type + " " + lines.get(i).line); } public static enum Type { ADDED, // New line added REMOVED, // Line deleted SAME // No change } public static class LineItem { public Type type; public String line; public LineItem(Type type, String line) { this.type = type; this.line = line; } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

7 August 2022, 08:49

To see the problem try these values orig: 9 8 7 updated: 8 7 (read how compare works... it does not really help you here as you require the lines to be sorted by natural order. Instead you should maybe read in more lines from the files, the current line and the next line. Then you compare current lines, if no match then current_orig -> updated_next and next_orig -> updated_current)

Coboliste

Level 46 , Casablanca, Morocco

7 August 2022, 10:02

Hi Thomas, yes, you are right my program require the file to be sorted in ascending order. I will modify it, thanks a lot, have a nice day.